Skip to content

samples: boards: stm32 main function return type from void to int #56947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
FRASTM wants to merge 1 commit into from
Closed

samples: boards: stm32 main function return type from void to int #56947

FRASTM wants to merge 1 commit into from

Conversation

@FRASTM
Copy link
Contributor

@FRASTM FRASTM commented Apr 17, 2023 •
edited
Loading

Return 0 on samples/boards/stm32/backup_sram/src/main.c to match the int type.

Regression due to commit 0b90fd5 (PR #54628)
causing compilation warning

./samples/boards/stm32/backup_sram/src/main.c: In function 'main':
./boards/stm32/backup_sram/src/main.c:24:17: warning: 'return' with no value, in function returning non-void [-Wreturn-type]
   24 |                 return;
      |                 ^~~~~~
./samples/boards/stm32/backup_sram/src/main.c:18:5: note: declared here
   18 | int main(void)
      |     ^~~~

Signed-off-by: Francois Ramu francois.ramu@st.com

@FRASTM
samples: boards: stm32 main function return type from void to int
689aaa0 
Return 0 on samples/boards/stm32/backup_sram/src/main.c
to match the int type.

Signed-off-by: Francois Ramu <francois.ramu@st.com>
@FRASTM FRASTM requested a review from nashif as a code owner April 17, 2023 14:56
@zephyrbot zephyrbot added the platform: STM32 ST Micro STM32 label Apr 17, 2023
@FRASTM FRASTM requested review from keith-packard and removed request for ABOSTM, GeorgeCGV, erwango and gautierg-st April 17, 2023 14:56
@FRASTM FRASTM added the Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc. label Apr 17, 2023
@FRASTM FRASTM requested review from erwango and gautierg-st April 17, 2023 14:57
@FRASTM FRASTM mentioned this pull request Apr 17, 2023
Merged
stephanosio
stephanosio reviewed Apr 17, 2023
View reviewed changes
Copy link
Member

@stephanosio stephanosio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was already fixed in #56927

@FRASTM
Copy link
Contributor Author

FRASTM commented Apr 17, 2023

closing as fixed already

@FRASTM FRASTM closed this Apr 17, 2023
@FRASTM FRASTM deleted the main_int branch April 17, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stephanosio stephanosio stephanosio left review comments

@nashif nashif Awaiting requested review from nashif

@keith-packard keith-packard Awaiting requested review from keith-packard

@erwango erwango Awaiting requested review from erwango

@gautierg-st gautierg-st Awaiting requested review from gautierg-st

Assignees

@erwango erwango

Labels

platform: STM32 ST Micro STM32 Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@FRASTM @stephanosio @erwango @zephyrbot