Skip to content

samples: modules: thrift: Add newlib filter to samples.yaml #57097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cfriedt merged 1 commit into from
May 4, 2023
Merged

samples: modules: thrift: Add newlib filter to samples.yaml #57097

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions samples/modules/thrift/hello/client/prj.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,10 @@
# CONFIG_LIB_CPLUSPLUS Dependencies
CONFIG_NEWLIB_LIBC=y
CONFIG_NEWLIB_LIBC_NANO=n
CONFIG_REQUIRES_FULL_LIBCPP=y
Copy link
Member

@cfriedt cfriedt May 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might even be better to move this to select REQUIRES_FULL_LIBCPP in modules/thrift/Kconfig.

Copy link
Member

@cfriedt cfriedt May 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish there were an ISO C code generator upstream (instead of the one that depends on glib)


# CONFIG_THRIFT Dependencies
CONFIG_CPP=y
CONFIG_STD_CPP17=y
CONFIG_CPP_EXCEPTIONS=y
CONFIG_EXTERNAL_LIBCPP=y
CONFIG_POSIX_API=y
CONFIG_NETWORKING=y
CONFIG_NET_SOCKETS=y
Expand Down
1 change: 1 addition & 0 deletions samples/modules/thrift/hello/client/sample.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ common:
modules:
- thrift
platform_allow: mps2_an385 qemu_x86_64
filter: CONFIG_FULL_LIBCPP_SUPPORTED
tests:
sample.thrift.hello.server.binaryProtocol: {}
sample.thrift.hello.server.compactProtocol:
Expand Down
4 changes: 1 addition & 3 deletions samples/modules/thrift/hello/server/prj.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,10 @@
# Need a full libc++
CONFIG_NEWLIB_LIBC=y
CONFIG_NEWLIB_LIBC_NANO=n
CONFIG_REQUIRES_FULL_LIBCPP=y

# CONFIG_THRIFT Dependencies
CONFIG_CPP=y
CONFIG_STD_CPP17=y
CONFIG_CPP_EXCEPTIONS=y
CONFIG_EXTERNAL_LIBCPP=y
CONFIG_POSIX_API=y
CONFIG_NET_SOCKETPAIR=y
CONFIG_HEAP_MEM_POOL_SIZE=16384
Expand Down
1 change: 1 addition & 0 deletions samples/modules/thrift/hello/server/sample.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ common:
modules:
- thrift
platform_allow: mps2_an385 qemu_x86_64
filter: CONFIG_FULL_LIBCPP_SUPPORTED
tests:
sample.thrift.hello.server.binaryProtocol: {}
sample.thrift.hello.server.compactProtocol:
Expand Down