posix: implement sched_rr_get_interval() #68316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moonlight83340
force-pushed
the
sched_rr_get_interval
branch
4 times, most recently
from
d05fcea to
ce6ce50
Compare
ycsin
reviewed
Jan 31, 2024
include/zephyr/posix/sched.h
Outdated
| @@ -10,6 +10,8 @@ | |||
|
|
|||
| #include "posix_types.h" | |||
|
|
|||
| #include "time.h" | |||
There was a problem hiding this comment.
I think this should be grouped with the posix_types.h above
moonlight83340
force-pushed
the
sched_rr_get_interval
branch
from
ce6ce50 to
b47eac4
Compare
ycsin
previously approved these changes
Jan 31, 2024
|
I will rebase tonight, my other PR has been merged so maybe the conflic is from that. |
moonlight83340
force-pushed
the
sched_rr_get_interval
branch
from
b47eac4 to
f280e31
Compare
cfriedt
reviewed
Jan 31, 2024
include/zephyr/posix/sched.h
Outdated
| @@ -9,6 +9,7 @@ | |||
| #include <zephyr/kernel.h> | |||
|
|
|||
| #include "posix_types.h" | |||
| #include "time.h" | |||
There was a problem hiding this comment.
This is a standard ISO C header file, so it should have angle brackets and have a newline after private headers (sorry, this is not yet built into .clang-format)
Suggested change
| #include "time.h" | |
| #include <time.h> |
There was a problem hiding this comment.
Noted, thank you !
moonlight83340
force-pushed
the
sched_rr_get_interval
branch
from
f280e31 to
52d61b5
Compare
cfriedt
previously approved these changes
Jan 31, 2024
ycsin
previously approved these changes
Feb 1, 2024
Implement `sched_rr_get_interval()` POSIX APIs as a part of PSE53 `_POSIX_PRIORITY_SCHEDULING` option group. Functions is actually placeholders and just return `ENOSYS` since Zephyr does not yet support processes or process scheduling. signed-off-by: Gaetan Perrot <gaetanperrotpro@gmail.com>
`sched_rr_get_interval()` is now implemented,mark it so. signed-off-by: Gaetan Perrot <gaetanperrotpro@gmail.com>
Implement tests for `sched_rr_get_interval()` . Function is actually placeholders and just return `ENOSYS` since Zephyr does not yet support processes or process scheduling. signed-off-by: Gaetan Perrot <gaetanperrotpro@gmail.com>
moonlight83340
force-pushed
the
sched_rr_get_interval
branch
from
52d61b5 to
f16e0f3
Compare
|
Rebase. |
ycsin
approved these changes
Feb 2, 2024
cfriedt
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the See #51211 (RFC #51211).
sched_rr_get_interval() is required as part of _POSIX_PRIORITY_SCHEDULING Option Group.
For more information, please refer to https://pubs.opengroup.org/onlinepubs/9699919799/functions/sched_rr_get_interval.html
Function is actually placeholders and just return
ENOSYSsince Zephyr does not yet support processes or process scheduling.
Fixes #66961