drivers: dma: dma_nxp_edma: allow channel re-configuration #68802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the state transition function doesn't allow the re-configuration of an already configured channel (i.e: CHAN_CONFIGURED -> CHAN_CONFIGURED transition). This causes problems when using `pulseaudio` and `SOF` because the same channel ends up being configured multiple times in the beginning due to how pulse seems to work. Logically speaking, re-configuring an already configured channel is not wrong so this commit solves the issue by allowing the CHAN_CONFIGURED -> CHAN_CONFIGURED transition. Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
5 tasks
zephyrbot
added
area: DMA
zephyrbot
requested review from
danieldegrasse,
dbaluta,
decsny,
dleach02,
manuargue,
mmahadevan108 and
teburd
dbaluta
approved these changes
Feb 26, 2024
|
@LaurentiuM1234 is it possible for Pulse to come and reconfigure your EDMA (already configured by SOF with config X) with config Y? |
This all happens during init so pulse shouldn't interfere with the configurations you set when doing for example |
|
Re-assigned to @dbaluta as these are NXP related changes for audio, please re-assign again if needed |
teburd
approved these changes
Mar 4, 2024
dbaluta
approved these changes
Mar 5, 2024
|
Thanks @teburd. This is good to be merged! I don't have merge rights, so can you please help merge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the state transition function doesn't allow the re-configuration of an already configured channel (i.e: CHAN_CONFIGURED -> CHAN_CONFIGURED transition). This causes problems when using
pulseaudioandSOFbecause the same channel ends up being configured multiple times in the beginning due to how pulse seems to work. Logically speaking, re-configuring an already configured channel is not wrong so this commit solves the issue by allowing the CHAN_CONFIGURED -> CHAN_CONFIGURED transition.