[hwm2] ci: update check_compliance to not create duplicate lines in Kconfig #68811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tejlmand
added
the
Hotfix
57300
reviewed
Feb 9, 2024
check_compliance generates Kconfig files for sourcing board and soc Kconfig tree in order to run compliance. Each board and soc generated a source entry, however several socs are using same soc dir and thus multiple identical source lines where created. Use a set() to ensure unique folders before generating Kconfig files. This ensures that each Kconfig file is only sourced once. This improves both compliance as fewer lines needs to be written, as well as improves Kconfiglib as fewer Kconfig files must be sourced, as redundant sourcing is not avoided. Signed-off-by: Torsten Rasmussen <Torsten.Rasmussen@nordicsemi.no>
tejlmand
force-pushed
the
hwmv2_check_compliance_kconfig
branch
from
ea8da19
to
4fac2ad
Compare
57300
approved these changes
Feb 9, 2024
henrikbrixandersen
changed the title
golowanow
approved these changes
Feb 9, 2024
This was referenced Feb 9, 2024
nordicjm
approved these changes
Feb 12, 2024
nordicjm
merged commit f56eab2
into
zephyrproject-rtos:collab-hwm
11 of 16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check_compliance generates Kconfig files for sourcing board and soc Kconfig tree in order to run compliance.
Each board and soc generated a source entry, however several socs are using same soc dir and thus multiple identical source lines where created.
Use a set() to ensure unique lines before generating Kconfig files. This ensures that each Kconfig file is only sourced once. This improves both compliance as fewer lines needs to be written, as well as improves Kconfiglib as fewer Kconfig files must be sourced, as redundant sourcing is not avoided.