hwmv2: microchip_mec: port to HWMv2 #69082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiobaltieri
commented
Feb 16, 2024
| @@ -216,7 +210,17 @@ config MCHP_HEADER_VERBOSE_OUTPUT | |||
|
|
|||
| endif # MCHP_MEC_UNSIGNED_HEADER | |||
|
|
|||
| # Select SoC Part No. and configuration options | |||
| source "soc/soc_legacy/arm/microchip_mec/*/Kconfig.soc" | |||
| config SOC_MEC172X_PROC_CLK_DIV | |||
There was a problem hiding this comment.
This one is used by mec15xx drivers as well as it turns out, should probably be renamed but I just moved it up the hierarchy in the interest of not changing the matching usage in drivers/
There was a problem hiding this comment.
Falls on the maintainers responsibility to fix
There was a problem hiding this comment.
yeah fine by me... I can also rename it here if you prefer, whatever, no difference but this change is needed for the boards to build
fabiobaltieri
force-pushed
the
mec-hwmv2
branch
3 times, most recently
from
4f4742b
to
8fd5d09
Compare
nordicjm
reviewed
Feb 19, 2024
| @@ -216,7 +210,17 @@ config MCHP_HEADER_VERBOSE_OUTPUT | |||
|
|
|||
| endif # MCHP_MEC_UNSIGNED_HEADER | |||
|
|
|||
| # Select SoC Part No. and configuration options | |||
| source "soc/soc_legacy/arm/microchip_mec/*/Kconfig.soc" | |||
| config SOC_MEC172X_PROC_CLK_DIV | |||
There was a problem hiding this comment.
Falls on the maintainers responsibility to fix
fabiobaltieri
force-pushed
the
mec-hwmv2
branch
from
8fd5d09
to
fb23de0
Compare
zephyrbot
requested review from
avisconti,
teburd,
tristan-google and
yperess
fabiobaltieri
force-pushed
the
mec-hwmv2
branch
from
fb23de0
to
5781527
Compare
|
Rebased as well, merge conflict on the doc index file. |
nordicjm
reviewed
Feb 20, 2024
Convert the Microchip MEC soc/ to hardware model v2. Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com>
Convert mec1501modular_assy6885, mec15xxevb_assy6853, mec172xevb_assy6906 and mec172xmodular_assy6930 to hwmv2. Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com>
Adjust few paths in the board document and maintainer file to reflect the new file location. Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com>
fabiobaltieri
force-pushed
the
mec-hwmv2
branch
from
5781527
to
024f48f
Compare
nordicjm
approved these changes
Feb 20, 2024
tejlmand
approved these changes
Feb 20, 2024
| @@ -12,7 +12,7 @@ endif() | |||
| if (DEFINED CONFIG_MCHP_MEC_UNSIGNED_HEADER) | |||
| set(MCHP_MEC_BIN_NAME ${CONFIG_KERNEL_BIN_NAME}.mchp.bin) | |||
| set_property(GLOBAL APPEND PROPERTY extra_post_build_commands | |||
| COMMAND ${PYTHON_EXECUTABLE} ${SOC_DIR}/${ARCH}/${SOC_FAMILY}/common/spigen/mec_spi_gen.py | |||
| COMMAND ${PYTHON_EXECUTABLE} ${ZEPHYR_BASE}/soc/microchip/mec/common/spigen/mec_spi_gen.py | |||
There was a problem hiding this comment.
No change requested, but want to point out that the following code resolves to same location:
Suggested change
| COMMAND ${PYTHON_EXECUTABLE} ${ZEPHYR_BASE}/soc/microchip/mec/common/spigen/mec_spi_gen.py | |
| COMMAND ${PYTHON_EXECUTABLE} ${CMAKE_CURRENT_LIST_DIR}/spigen/mec_spi_gen.py |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port the MEC soc and boards to hwmv2.