twister: normalize platform name when storing files/data #69338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PerMac
requested changes
Feb 22, 2024
Comment on lines
67
to
68
| print(self.build_dir) | ||
| print(platform.sane_name) |
PerMac
added
the
Trivial
hakehuang
approved these changes
Feb 22, 2024
|
a nit (?): https://developers.google.com/style/word-list#sane I remember we we had to change sanitycheck before and this seems similar case |
nashif
force-pushed
the
topic/hwm/sane_platform_names
branch
from
933c023
to
5fb02a1
Compare
PerMac
approved these changes
Feb 22, 2024
nashif
requested review from
lorc,
xakep-amatop,
carlocaione,
povergoing,
firscity,
sidcha,
Navin-Sankar,
aaillet,
erwango,
ABOSTM,
FRASTM,
avisconti,
nandojve and
parthitce
as code owners
carlescufi
requested review from
tejlmand and
nordicjm
and removed request for
aaillet,
ABOSTM,
FRASTM,
ibirnbaum,
golowanow,
MulinChao,
ChiHuaL,
gopiotr,
firscity,
gchwier,
dleach02,
simonguinot,
jackrosenthal,
ifyall,
npal-cy,
vanti,
greg-leach,
LingaoM and
soburi
Use mps2/an385 for testing the hwmv2 board names. Signed-off-by: Anas Nashif <anas.nashif@intel.com>
Convert slashes into underscores to allow saving of data related to platforms on disk. Signed-off-by: Anas Nashif <anas.nashif@intel.com>
nashif
force-pushed
the
topic/hwm/sane_platform_names
branch
from
6a76704
to
efda3be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert slashes into underscores to allow saving of data related to
platforms on disk.
Signed-off-by: Anas Nashif anas.nashif@intel.com