Skip to content

soc: intel_ish: Make ISH support APIC timer with TSC time source. #72843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 12, 2024
Merged

soc: intel_ish: Make ISH support APIC timer with TSC time source. #72843

merged 1 commit into from
Jun 12, 2024

Conversation

kwd-doodling
Copy link
Contributor

@kwd-doodling kwd-doodling commented May 16, 2024 •
edited
Loading

This commit enables ISH boards to use APIC timer with TSC time source as
their system timer by replacing CONFIG_HPET with CONFIG_APIC_TIMER_TSC.

@zephyrbot zephyrbot added the platform: Intel ISH Intel Corporation, Integrated Sensor Hub label May 16, 2024
@zephyrbot zephyrbot requested a review from teburd May 16, 2024 06:44
@kwd-doodling kwd-doodling requested a review from tejlmand May 16, 2024 06:45
teburd
teburd previously approved these changes May 16, 2024
View reviewed changes
@teburd teburd requested review from dcpleung and nashif May 16, 2024 14:20
@teburd
Copy link
Contributor

teburd commented May 16, 2024 •
edited
Loading

I guess a question here would be, as @andyross noted, why don't we use the apic_tsc timer driver in place of apic, if the end goal is using apic tsc with #72839

@teburd teburd dismissed their stale review May 16, 2024 15:30

In light of apic_tsc existing I think we need to ask why we don't use that instead

@kwd-doodling
Copy link
Contributor Author

I guess a question here would be, as @andyross noted, why don't we use the apic_tsc timer driver in place of apic, if the end goal is using apic tsc with #72839

ISH is a legacy CPU in fact :) Run apic_tsc on ISH already, ASSERT on "__ASSERT((ecx & BIT(24)) != 0, "No TSC Deadline support");"

@kwd-doodling kwd-doodling requested a review from teburd May 17, 2024 02:44
teburd
teburd previously approved these changes May 17, 2024
View reviewed changes
@kwd-doodling kwd-doodling force-pushed the ish_with_apic_timer branch from 079889a to 609cca8 Compare May 22, 2024 01:31
@kwd-doodling kwd-doodling force-pushed the ish_with_apic_timer branch from 609cca8 to 926a3b5 Compare May 31, 2024 03:09
@kwd-doodling kwd-doodling changed the title soc: intel_ish: Add APIC timer support for ISH soc: intel_ish: Make ISH support APIC timer with TSC time source. May 31, 2024
@kwd-doodling
Copy link
Contributor Author

update this patch after #72839 was abandoned and #73185 was merged.

teburd
teburd previously approved these changes May 31, 2024
View reviewed changes
@teburd teburd requested a review from edersondisouza June 11, 2024 17:50
edersondisouza
edersondisouza reviewed Jun 11, 2024
View reviewed changes
@kwd-doodling
soc: intel_ish: Make ISH support APIC timer with TSC time source.
3d8c3fc 
This commit enables ISH boards to use APIC timer with TSC time source as
their system timer by replacing CONFIG_HPET with CONFIG_APIC_TIMER_TSC.

Signed-off-by: Dong Wang <dong.d.wang@intel.com>
@kwd-doodling kwd-doodling force-pushed the ish_with_apic_timer branch from 926a3b5 to 3d8c3fc Compare June 12, 2024 01:43
@dleach02 dleach02 merged commit 521a5ca into zephyrproject-rtos:main Jun 12, 2024
@kwd-doodling kwd-doodling mentioned this pull request Jun 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teburd teburd teburd approved these changes

@edersondisouza edersondisouza edersondisouza approved these changes

@tejlmand tejlmand Awaiting requested review from tejlmand

@dcpleung dcpleung Awaiting requested review from dcpleung

@nashif nashif Awaiting requested review from nashif

Assignees

@kwd-doodling kwd-doodling

Labels
platform: Intel ISH Intel Corporation, Integrated Sensor Hub
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kwd-doodling @teburd @edersondisouza @zephyrbot @dleach02