Add MAX32672 #73573
Add MAX32672 #73573
Conversation
zephyrbot
requested review from
galak,
henrikbrixandersen,
MaureenHelm,
microbuilder and
mnkp
ozersa
force-pushed
the
add-MAX32672
branch
2 times, most recently
from
d2257c9 to
b356b08
Compare
|
Need to rebase and resolve conflicts |
One more time, please. |
Add MAX32672 Kconfig and dts files Co-authored-by: Maureen Helm <maureen.helm@analog.com> Signed-off-by: Sadik Ozer <sadik.ozer@analog.com>
Sure, done. |
|
@microbuilder @galak please take a look |
There was a problem hiding this comment.
all the images in your PR are of pretty low quality / blurry. Based on the size of the files, I understand this might be due to JPEG compression as you probably tried to aim for 100K or less :) I would recommend you look at using WEBP for better quality/size ratio. Make sure to use the "original" images as your source when converting to webp (using eg cwebp) and not the already degraded jpeg images from this PR
please feel free to use https://gist.githubusercontent.com/kartben/3c91fef0f7808111350afc737a3f08e7/raw/aa5728643dc0c82a21b357124b9aecbbf4bc0564/max32672evkit_img1.webp directly (54KB)
There was a problem hiding this comment.
Thanks for information, applied.
There was a problem hiding this comment.
drop the back picture (and associated file of course) as the added value is limited and this will save 10s of KBs from upstream git repo
There was a problem hiding this comment.
Correct, removed.
Thanks
There was a problem hiding this comment.
You are wrapping very aggressively, which hurt readability and will generate larger than necessary diffs in the future.
Please adjust line length to 100 characters in your editor and update RST files in this PR accordingly :)
There was a problem hiding this comment.
ditto earlier comment: not convinced you need the back here either
ozersa
force-pushed
the
add-MAX32672
branch
2 times, most recently
from
9235fce to
c0cb754
Compare
Added MAX32672FTHR board For more information about this board please check https://www.analog.com/ Co-authored-by: Maureen Helm <maureen.helm@analog.com> Signed-off-by: Sadik Ozer <sadik.ozer@analog.com>
|
As per of below error Added an event code. |
Add MAX32672EVKIT board files For more information about this board please check https://www.analog.com/ Co-authored-by: Maureen Helm <maureen.helm@analog.com> Signed-off-by: Sadik Ozer <sadik.ozer@analog.com>
Enable gpio driver test for max32672evkit and fthr boards Signed-off-by: Sadik Ozer <sadik.ozer@analog.com>
The MAX32672 microcontroller (MCU) is an advanced system-on-chip (SoC) featuring an Arm® Cortex®-M4F.
This PR add MAX32672 and it boards by providing basic functionalities
Below tests executed on both MAX32672EVKIT and MAX32672FTHR boards.
Tested with:
blinky example
button example
gpio_basic_api test
uart_basic_api test
