soc/*adsp: Fix snippets linkage #75055
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Intel and NXP adsp linker scripts (mostly evolved via cut/paste
between themselves) never actually had support for linker "sections"
snippets as e.g. needed for STRUCT_SECTION_ITERABLE() usage[1]. Add
them in reasonably appropriate places (Intel doesn't really have a
clean .rodata area, because of the way cache address munging works, so
in fact they're adjacent there).
[1] Actually cAVS did have the include for ROM snippets, but it was in
the wrong place and dumped the symbols into unusable addresses at
the top of memory.
Signed-off-by: Andy Ross <andyross@google.com>
zephyrbot
added
platform: NXP Xtensa
platform: NXP MPU
platform: Intel ADSP
zephyrbot
requested review from
ceolin,
danieldegrasse,
dbaluta,
dcpleung,
decsny,
dleach02,
iuliana-prodan,
JiafeiPan,
kv2019i,
lgirdwood,
lyakh,
marc-hb,
softwarecki,
tmleman and
yvanderv
|
See thesofproject/sof#9261 for the SOF PR that needs this |
|
Actually, closing this. It turns out that the SECTIONS snippets linkage is complicated on the intel_adsp devices because the cache/uncache flipping interacts with the fact that idtlist.ld is included in that snippet level, and it needs to link somewhere else. Also there's a brand new ROM_SECTIONS snippet type from @pdgendt that literally just merged last week in #71911 which will work great; I'll use that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Intel and NXP adsp linker scripts (mostly evolved via cut/paste between themselves) never actually had support for linker "sections" snippets as e.g. needed for STRUCT_SECTION_ITERABLE() usage[1]. Add them in reasonably appropriate places (Intel doesn't really have a clean .rodata area, because of the way cache address munging works, so in fact they're adjacent there).
[1] Actually cAVS did have the include for ROM snippets, but it was in
the wrong place and dumped the symbols into unusable addresses at
the top of memory.