ace: power: replace pseudo-assembly movi #75174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When switching off memory banks we cannot use movi with arbitrary immediate arguments, they will be converted by the compiler to memory accesses. Only constants within the allowed range should be used. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
zephyrbot
requested review from
andyross,
ceolin,
dcpleung,
jxstelter,
kv2019i,
lgirdwood,
marc-hb,
marcinszkudlinski,
nashif,
softwarecki and
tmleman
|
As we've verified, this PR doesn't fix thesofproject/sof#9268 but the code that it replaces does seem to be dangerous, as identified by @andyross |
andyross
approved these changes
Jul 2, 2024
dcpleung
approved these changes
Jul 2, 2024
ceolin
approved these changes
Jul 3, 2024
|
This change causes failures in all power flows on MTL/LNL/PTL. Considering that it wasn't a fix for any known issue, I suggest simply reverting it #75689. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When switching off memory banks we cannot use movi with arbitrary immediate arguments, they will be converted by the compiler to memory accesses. Only constants within the allowed range should be used.