drivers: flash: merger Generic SPI Flash driver #7561

findlayfeng · 2018-05-16T01:46:32Z

Merged #5456.
Update spi api.
Add the CS/gpio logic.
Independent of spi flash config.

findlayfeng · 2018-05-16T01:47:19Z

codecov-io · 2018-05-16T02:07:50Z

Codecov Report

Merging #7561 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7561   +/-   ##
=======================================
  Coverage   53.22%   53.22%           
=======================================
  Files         217      217           
  Lines       26668    26668           
  Branches     5914     5914           
=======================================
  Hits        14193    14193           
  Misses      10059    10059           
  Partials     2416     2416

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51c7b5f...ca75a7e. Read the comment docs.

tbursztyka

Seems fine to me (remove the 'etc' in last patch's commit title).

Note that you don't have to close and create a new PR each time you make changes to your patches: a git push -f will just do, and all will be updated in existing PR.

findlayfeng · 2018-05-16T07:30:11Z

嗯，我尝试过push -f但是，不清楚是因为有三次commit 还是因为是一个空格改制表符的空提交，一直成功但没有被修改。正好提示有一个不兼容的合并，于是我就新拉取了一个分支做处理。
Below from Google Translate
Well, I tried push -f , and it's unclear whether there were three commit or because it was an empty commit of a space change tab, it was successful but not modified. Just in case there is an incompatible merge, so I took a new branch to do the processing.

findlayfeng · 2018-06-04T02:16:50Z

@tbursztyka Made more changes in this patch

tbursztyka

you will need to rebase and update that against latest SPI API. Also, add support for CS GPIO (see existing code such as spi_flash_w25qxxdv.c)

tbursztyka · 2018-06-14T12:53:19Z

drivers/flash/Kconfig

+	default ""
+
+config SPI_FLASH_SFDP_INIT_PRIORITY
+	int


no prompt for that one?

tbursztyka · 2018-06-14T12:53:40Z

drivers/flash/Kconfig

+	  Flash Discoverable Parameters (SFDP).
+
+config SPI_FLASH_SFDP_SPI_NAME
+	string


get rid of prompt and put the prompt message here.

tbursztyka · 2018-06-14T12:55:39Z

drivers/flash/spi_flash_sfdp.c

+				phdr[i].major_ver, phdr[i].minor_ver,
+				get_phdr_addr(&phdr[i]),
+				phdr[i].length);
+		switch (get_phdr_id(&phdr[i])) {


why a switch if there is only 1 case?

tbursztyka · 2018-06-14T12:57:55Z

drivers/flash/spi_flash_sfdp.c

+	wait_for_flash_idle(dev);
+	i = 0;
+	hdr[i++] = data->read_opcode;
+	if (data->addr_len == 4) {


add an empty line before

tbursztyka · 2018-06-14T12:58:09Z

drivers/flash/spi_flash_sfdp.c

+	if (data->addr_len == 4) {
+		hdr[i++] = offset >> 24;
+	}
+	hdr[i++] = offset >> 16;


tbursztyka · 2018-06-14T12:58:20Z

drivers/flash/spi_flash_sfdp.c

+	hdr[i++] = offset >> 16;
+	hdr[i++] = offset >> 8;
+	hdr[i++] = offset;
+	r = spi_transceive(&data->config, txbufs, ARRAY_SIZE(txbufs),


tbursztyka · 2018-06-14T12:58:59Z

drivers/flash/spi_flash_sfdp.c

+
+	SYS_LOG_DBG("write: @%x len %x, opcode %x (page size %d)",
+		offset, len,
+		data->write_opcode, data->page_size);


hum, you can put that on previous line

tbursztyka · 2018-06-14T12:59:30Z

drivers/flash/spi_flash_sfdp.c

+
+	i = 0;
+	hdr[i++] = data->write_opcode;
+	if (data->addr_len == 4) {


add an empty line before (basicall: if assigned value is not used in the if condition: break a line).

tbursztyka · 2018-06-14T12:59:51Z

drivers/flash/spi_flash_sfdp.c

+	if (data->addr_len == 4) {
+		hdr[i++] = offset >> 24;
+	}
+	hdr[i++] = offset >> 16;


same here (break a line if it's not another '}' etc...)

findlayfeng · 2018-06-15T09:32:29Z

88688ce 来自 Merged #5456，我只是让它变得可合并而已,我在 ff2e7ec 中做了自己的工作，包括gpio_cs，几乎重写了。
From google translate
88688ce from Merged #5456, I just made it mergeable, I did my work in ff2e7ec, including gpio_cs, which was almost rewritten.
@tbursztyka

tbursztyka · 2018-06-28T06:03:42Z

drivers/flash/spi_flash_sfdp.h

+#define CONFIG_SPI_FLASH_SMPT_SIZE 16
+#endif
+
+typedef u32_t dword_t;


why this typedef? Seems unnecessary

dword 是SFDP文档里定义的最小组成单位
From Google Translate
Dword is the smallest unit of definition defined in the SFDP document

tbursztyka · 2018-06-28T06:05:45Z

drivers/flash/spi_flash_sfdp.c

@@ -1,558 +1,993 @@
 /*
 * Copyright (c) 2017 Crypta Labs Ltd
+ * Copyright (c) 2018 Findlay Feng


Merge this specific modification of sfdp to your first commit.

And this actual commit becomes one for adding microchip table support then.

I will change it

tbursztyka · 2018-06-28T06:07:21Z

drivers/flash/spi_flash_sfdp.c

-		.frequency = CONFIG_SPI_FLASH_SFDP_SPI_FREQ_0,
-		.operation = SPI_WORD_SET(8),
-	};
+#if defined(SPI_FLASH_GPIO_SPI_CS)


Why not a Kconfig option for this? So it would be CONFIG_ prefixed then.

oh...
This is a lapse

fabled · 2018-08-04T00:21:14Z

Looks interesting and seems to supercede my work. However, is dual/quad supported tested? I don't see any existing SPI driver supporting them, and my CEC QMSPI driver cannot support it until the descriptors are setup properly to indicate direction correctly - in these modes the data flows one direction only per cycle and the code and SPI API needs to support signalling which bytes are to be written and which are to be read.

fabled · 2018-08-04T00:36:37Z

Also overriding the configuration SPI freq does not seem right. This happens for reading SFDP table, and when microchip flash is detected.

findlayfeng · 2018-08-04T00:37:36Z

I only tried the standard spi, it is estimated that the dual spi is working, the quad spi still needs some extra work, I have left a lot of todo, and can improve it when needed.
Currently I don't have the right hardware to test.

findlayfeng · 2018-08-04T00:39:47Z

There is a definition of the read frequency that should be used in the SFDP document. This frequency is not necessarily the same as the one specified in the chip documentation.

findlayfeng · 2018-08-04T00:41:53Z

I use the nrf5x spi driver, the memory address of the configuration information does not change without modifying the actual configuration of the spi. . .

fabled · 2018-08-04T03:05:24Z

It is still normal that lower frequency is needed to be used. I think the configuration provided frequency should be honored. I rebased my spi sfdp driver on top of current head just to get everything I needed working - e.g. seems the microchip global unlock is not yet supported properly.

findlayfeng · 2018-08-04T03:21:31Z

My idea about the frequency is that when the device is not found, the speed specified by SFDP can be viewed at https://www.jedec.org/system/files/docs/JESD216B.pdf. Switch to the rate supported by the target device after the type.
In addition, the global unlocking problem of the Microchip chip, which is tested here, works fine.
Here, the Microchip chip only provides the global unlock command, but there is no fast global lock operation. Here I will call the unlock command the first time, then the software will control whether it is allowed to be written.

findlayfeng · 2018-08-04T03:32:26Z

page 3

4.4 Clock Rate
SFDP compliant devices must support 50 MHz operation for the Read SFDP command (instruction 5Ah).
Devices may support a wider frequency range, but a controller can always run SFDP cycles at 50 MHz or
less and get valid results.

This drivers supports chips with Serial Flash Discoverable Parameters (SFDP) information. Add Kconfig.spi Add spi_flash_sfdp.c Add spi_flash_sfdp.h Support spi dual mode Partial support spi quad mode Signed-off-by: Timo Teräs <timo.teras@iki.fi> Signed-off-by: Findlay Feng <i@fengch.me>

Supports Microchip SFDP table Add Kconfig.spi.microchip Add spi_flash_sfdp_microchip.h Add spi_flash_sfdp_microchip.c Signed-off-by: Findlay Feng <i@fengch.me>

id SPI_FLASH_0_ID; name CONFIG_SPI_FLASH_DRV_NAME; Signed-off-by: Findlay Feng <i@fengch.me>

galak · 2019-09-19T17:20:22Z

We have a spi_nor driver in tree. Please update any features like SFDP to that driver. Closing this PR at this point.

findlayfeng requested a review from nashif as a code owner May 16, 2018 01:46

tbursztyka approved these changes May 16, 2018

View reviewed changes

findlayfeng force-pushed the fix_spi_flash branch 2 times, most recently from 2bcf0a4 to cf3b296 Compare May 17, 2018 00:34

findlayfeng force-pushed the fix_spi_flash branch 3 times, most recently from 23ad35f to 10994fe Compare June 4, 2018 02:13

findlayfeng force-pushed the fix_spi_flash branch from 10994fe to ff2e7ec Compare June 6, 2018 02:50

nashif added this to the v1.13.0 milestone Jun 6, 2018

tbursztyka requested changes Jun 14, 2018

View reviewed changes

findlayfeng force-pushed the fix_spi_flash branch 3 times, most recently from 020b1f0 to 88c6f2e Compare June 27, 2018 09:51

tbursztyka requested changes Jun 28, 2018

View reviewed changes

findlayfeng force-pushed the fix_spi_flash branch 4 times, most recently from b16d060 to 6068e8a Compare June 29, 2018 07:37

vanwinkeljan mentioned this pull request Aug 15, 2018

Add a generic SPI NOR flash driver instead of the specific w25qxxdv driver #9078

Closed

nashif modified the milestones: v1.13.0, v1.14.0 Aug 28, 2018

nashif added area: SPI SPI bus area: Flashing area: Flash and removed area: Flashing area: SPI SPI bus labels Sep 14, 2018

findlayfeng mentioned this pull request Sep 28, 2018

flash_map: generate content from DTS completely. #8837

Merged

10 tasks

nvlsianpu mentioned this pull request Sep 28, 2018

External flash driver for the MX25Rxx #9873

Closed

fabled and others added 3 commits November 2, 2018 16:41

driver: spi_flash: add Microchip SFDP table

b19877f

Supports Microchip SFDP table Add Kconfig.spi.microchip Add spi_flash_sfdp_microchip.h Add spi_flash_sfdp_microchip.c Signed-off-by: Findlay Feng <i@fengch.me>

subsys: flash_map: Add SPI_FLASH to flash_drivers_map

ca75a7e

id SPI_FLASH_0_ID; name CONFIG_SPI_FLASH_DRV_NAME; Signed-off-by: Findlay Feng <i@fengch.me>

findlayfeng force-pushed the fix_spi_flash branch from 6068e8a to ca75a7e Compare November 2, 2018 08:44

findlayfeng mentioned this pull request Nov 14, 2018

drivers: flash: QSPI flash driver for nRF52 SoC #11278

Closed

vanwinkeljan mentioned this pull request Jan 2, 2019

Spi flash_map for intel_s1000 #11850

Merged

galak removed this from the v1.14.0 milestone Feb 5, 2019

markus-becker-tridonic-com mentioned this pull request Jun 14, 2019

Multi flash mcu-tools/mcuboot#359

Merged

aescolar added the Stale PR label Sep 18, 2019

galak closed this Sep 19, 2019

findlayfeng deleted the fix_spi_flash branch April 19, 2023 03:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

drivers: flash: merger Generic SPI Flash driver #7561

drivers: flash: merger Generic SPI Flash driver #7561

findlayfeng commented May 16, 2018

findlayfeng commented May 16, 2018

codecov-io commented May 16, 2018 •

edited

Loading

tbursztyka left a comment

findlayfeng commented May 16, 2018

findlayfeng commented Jun 4, 2018

tbursztyka left a comment

tbursztyka Jun 14, 2018

tbursztyka Jun 14, 2018

tbursztyka Jun 14, 2018

tbursztyka Jun 14, 2018

tbursztyka Jun 14, 2018

tbursztyka Jun 14, 2018

tbursztyka Jun 14, 2018

tbursztyka Jun 14, 2018

tbursztyka Jun 14, 2018

findlayfeng commented Jun 15, 2018 •

edited

Loading

tbursztyka Jun 28, 2018

findlayfeng Jun 28, 2018

tbursztyka Jun 28, 2018

tbursztyka Jun 28, 2018

findlayfeng Jun 28, 2018

tbursztyka Jun 28, 2018

findlayfeng Jun 28, 2018

fabled commented Aug 4, 2018

fabled commented Aug 4, 2018

findlayfeng commented Aug 4, 2018

findlayfeng commented Aug 4, 2018

findlayfeng commented Aug 4, 2018

fabled commented Aug 4, 2018

findlayfeng commented Aug 4, 2018

findlayfeng commented Aug 4, 2018

galak commented Sep 19, 2019

drivers: flash: merger Generic SPI Flash driver #7561

drivers: flash: merger Generic SPI Flash driver #7561

Conversation

findlayfeng commented May 16, 2018

findlayfeng commented May 16, 2018

codecov-io commented May 16, 2018 • edited Loading

Codecov Report

tbursztyka left a comment

Choose a reason for hiding this comment

findlayfeng commented May 16, 2018

findlayfeng commented Jun 4, 2018

tbursztyka left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

findlayfeng commented Jun 15, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fabled commented Aug 4, 2018

fabled commented Aug 4, 2018

findlayfeng commented Aug 4, 2018

findlayfeng commented Aug 4, 2018

findlayfeng commented Aug 4, 2018

fabled commented Aug 4, 2018

findlayfeng commented Aug 4, 2018

findlayfeng commented Aug 4, 2018

galak commented Sep 19, 2019

codecov-io commented May 16, 2018 •

edited

Loading

findlayfeng commented Jun 15, 2018 •

edited

Loading