net: sockets: tls: Fix poll update event check #75931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jukkar
approved these changes
Jul 16, 2024
In case POLLIN is set, and no new application data has been detected, the ztls_poll_update_ctx() should only return -EAGAIN if no other events are available for the socket. Otherwise, the function may end up busy-looping, in case for example POLLOUT is also monitored for the socket. Current check verifying that was wrong, as it caused to function to return -EAGAIN even if some other events could've been reported for the socket. Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
rlubos
force-pushed
the
net/dtls-nsos-busy-looping
branch
from
e0274a3 to
5cc5cc5
Compare
pdgendt
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case POLLIN is set, and no new application data has been detected, the ztls_poll_update_ctx() should only return -EAGAIN if no other events are available for the socket. Otherwise, the function may end up busy-looping, in case for example POLLOUT is also monitored for the socket.
Current check verifying that was wrong, as it caused to function to return -EAGAIN even if some other events could've been reported for the socket.
Fixes #75909