[Backport v3.7-branch] Bluetooth: L2CAP: Set NULL callback for PDUs #76770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Print user_data and callback pointers. Signed-off-by: Jonathan Rico <jonathan.rico@nordicsemi.no> (cherry picked from commit d02a13d)
Werror fails the build on that function. Signed-off-by: Jonathan Rico <jonathan.rico@nordicsemi.no> (cherry picked from commit 5c6cd27)
Storing stuff in user_data? That's a paddlin' We have been debugging issue after issue because ownership of this "user" data is not clearly defined. Now it is. L2CAP owns the user_data field entirely, as soon as `send()` is called. Also add a warning and retval using CHECKIF. Signed-off-by: Jonathan Rico <jonathan.rico@nordicsemi.no> (cherry picked from commit ea94499)
Modify the test so it checks that user_data is used and then cleared by the stack. Signed-off-by: Jonathan Rico <jonathan.rico@nordicsemi.no> (cherry picked from commit 08706f9)
It's already done. Signed-off-by: Jonathan Rico <jonathan.rico@nordicsemi.no> (cherry picked from commit 8d7c1bc)
It was not being set, and thus if the user_data contained garbage from before, then conn.c would attempt to call that garbage. Static channels don't have this issue, as every "SDU" fits into one PDU. Signed-off-by: Jonathan Rico <jonathan.rico@nordicsemi.no> Co-authored-by: Huajiang Zheng <nxf88597@lsv051208.swis.nl-cdc01.nxp.com> (cherry picked from commit 1c65103)
zephyrbot
added
Backport
zephyrbot
requested review from
aescolar,
alwa-nordic,
asbjornsabo,
hermabe,
jhedberg,
jori-nordic,
sjanc,
Thalley,
theob-pro and
Vudentz
aescolar
approved these changes
Aug 8, 2024
jhedberg
approved these changes
Aug 8, 2024
jori-nordic
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1c65103~6..1c65103 from #76489.
Fixes #76738