kernel: dynamic: use 4k stack size for x86 #79443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfriedt
added
area: X86
zephyrbot
requested review from
TaiJuWu,
andyross,
ceolin,
dcpleung,
nashif,
npitre,
peter-mitsis and
ycsin
peter-mitsis
previously approved these changes
Oct 4, 2024
cfriedt
force-pushed
the
use-4k-dynamic-thread-stack-sizes-to-silence-x86-problems
branch
from
382c39a to
816921c
Compare
Member
Author
|
ghost
mentioned this pull request
cfriedt
force-pushed
the
use-4k-dynamic-thread-stack-sizes-to-silence-x86-problems
branch
from
816921c to
8d8cb1f
Compare
Member
Author
|
Additional tuned configuration parameters for |
x86 architectures require a dynamic stack size that is a multiple of 4096 bytes due to mmu restrictions. For example, this test would previously fail when using the default dynamic stack size of 1024 bytes for 32-bit platforms. ``` west build -p auto -b qemu_x86/atom/nopae -t run \ tests/posix/common/ -- -DCONFIG_USERSPACE=y ``` It would pass with an additional argument ``` west build -p auto -b qemu_x86/atom/nopae -t run \ tests/posix/common/ -- -DCONFIG_USERSPACE=y \ -DCONFIG_DYNAMIC_THREAD_STACK_SIZE=4096 ``` Add a special default for x86 when using dynamic thread stacks. The x86 default removes the need for `boards/qemu_x86*.conf`, with the exception of `qemu_x86_tiny`. qemu_x86_tiny did not have sufficient memory (or configuration) to run the non-userspace tests, so bump up the available ram from 256k to 512k for this test and clone the .conf from the demand paging tests. Eventually, the common posix test should be split into more concise functional categories. Signed-off-by: Chris Friedt <cfriedt@tenstorrent.com>
cfriedt
force-pushed
the
use-4k-dynamic-thread-stack-sizes-to-silence-x86-problems
branch
from
8d8cb1f to
cc1b09d
Compare
cfriedt
changed the title
cfriedt
changed the title
ycsin
approved these changes
Oct 5, 2024
Member
ycsin
left a comment
ycsin
left a comment
There was a problem hiding this comment.
I wonder if having a BUILD_ASSERT somewhere to make sure that it is always the multiple of 4096 would help?
Member
Author
Actually, there are per-arch macros that should round / pad stacks. It's confusing to me why they don't seem to work for x86. The extra .conf is required for for tiny as well. |
15 tasks
bjarki-andreasen
approved these changes
Oct 5, 2024
cfriedt
deleted the
use-4k-dynamic-thread-stack-sizes-to-silence-x86-problems
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
x86 architectures require a dynamic stack size that is a multiple of 4096 bytes due to mmu restrictions.
For example, this test would previously fail when using the default dynamic stack size of 1024 bytes for 32-bit platforms (because a specific board configuration file was not present).
It would pass with an additional argument
Add a special default for x86 when using dynamic thread stacks.
The x86 default removes the need for
boards/qemu_x86*.conf, with the exception ofqemu_x86_tiny.qemu_x86_tinydid not have sufficient memory (or configuration) to run the non-userspace tests, so bump up the available ram from 256k to 512k for this test and clone the.conffrom the demand paging tests.Eventually, the common posix test should be split into more concise functional categories to reduce ram requirements.