tests: posix: common: separate posix signal tests into a standalone test #80862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycsin
requested changes
Nov 5, 2024
Pancakem
force-pushed
the
separate_posix_signal_test_into_smaller_testsuite
branch
2 times, most recently
from
495aaa5 to
1d60f2a
Compare
cfriedt
approved these changes
Nov 5, 2024
Member
|
I think this looks ok |
cfriedt
approved these changes
Nov 6, 2024
cfriedt
requested changes
Nov 6, 2024
cfriedt
reviewed
Nov 6, 2024
Pancakem
force-pushed
the
separate_posix_signal_test_into_smaller_testsuite
branch
from
579f746 to
92aa0e8
Compare
cfriedt
requested changes
Nov 13, 2024
Member
cfriedt
left a comment
cfriedt
left a comment
There was a problem hiding this comment.
It looks like PSE51 is needed for signals.
Pancakem
force-pushed
the
separate_posix_signal_test_into_smaller_testsuite
branch
2 times, most recently
from
f03f479 to
f06a573
Compare
cfriedt
requested changes
Nov 27, 2024
Member
cfriedt
left a comment
cfriedt
left a comment
There was a problem hiding this comment.
The filters should probably be part of common, rather than 1 particular test configuration.
Pancakem
force-pushed
the
separate_posix_signal_test_into_smaller_testsuite
branch
from
f06a573 to
8abfdcd
Compare
…suite posix.common contains testsuites that can be separated into smaller groups of tests. This change moves signal tests into a singular testsuite at tests/posix/signals app directory. Signed-off-by: Marvin Ouma <pancakesdeath@protonmail.com>
Pancakem
force-pushed
the
separate_posix_signal_test_into_smaller_testsuite
branch
from
8abfdcd to
191f7b2
Compare
ycsin
approved these changes
Nov 28, 2024
cfriedt
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #80930
posix.common contains testsuites that can be separated into standalone tests. This change moves signal tests into a singular testsuite at tests/posix/signal app directory.