Skip to content

Replace runtime checks with buildtime asserts in iCE40 #81560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
henrikbrixandersen merged 1 commit into from
Nov 21, 2024
Merged

Replace runtime checks with buildtime asserts in iCE40 #81560

henrikbrixandersen merged 1 commit into from
Nov 21, 2024

Conversation

@benediktibk
Copy link
Contributor

@benediktibk benediktibk commented Nov 19, 2024

Replace NULL checks for the set and clear registers with BUILD_ASSERTs in the iCE40 device instantiation.

@benediktibk benediktibk force-pushed the change/ice40_build_time_checks branch from 4b885de to c82b41c Compare November 19, 2024 14:23
@benediktibk benediktibk marked this pull request as ready for review November 19, 2024 14:23
@zephyrbot zephyrbot added the area: FPGA Field-Programmable Gate Array (FPGA) label Nov 19, 2024
@benediktibk benediktibk mentioned this pull request Nov 20, 2024
Closed
@benediktibk benediktibk requested a review from josuah November 20, 2024 11:52
josuah
josuah approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@josuah josuah left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read the asserts as: "Either it has SPI, either it has all of creset-gpios, cdone-gpios, clk-gpios, pico-gpios, gpios-set-reg, gpios-clear-reg set".
Nice!

@benediktibk
drivers: fpga: replace runtime checks with buildtime asserts in iCE40
b848f13 
Replace NULL checks for the set and clear registers with BUILD_ASSERTs
in the iCE40 device instantiation.

Signed-off-by: Benedikt Schmidt <benedikt.schmidt@embedded-solutions.at>
@benediktibk benediktibk force-pushed the change/ice40_build_time_checks branch from c82b41c to b848f13 Compare November 20, 2024 14:14
@henrikbrixandersen henrikbrixandersen merged commit 53ae195 into zephyrproject-rtos:main Nov 21, 2024
23 checks passed
@benediktibk benediktibk deleted the change/ice40_build_time_checks branch November 22, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cfriedt cfriedt cfriedt approved these changes

@josuah josuah josuah approved these changes

@fkokosinski fkokosinski Awaiting requested review from fkokosinski

@msierszulski msierszulski Awaiting requested review from msierszulski

@tgorochowik tgorochowik Awaiting requested review from tgorochowik

Assignees

@cfriedt cfriedt

Labels

area: FPGA Field-Programmable Gate Array (FPGA)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@benediktibk @cfriedt @josuah @henrikbrixandersen @zephyrbot