nrf_usbd_common: Do not trigger DMA in low power mode #81596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfischer-no
reviewed
Nov 19, 2024
tmon-nordic
force-pushed
the
nrf-usbd-suspend
branch
from
7d55385 to
86be527
Compare
jfischer-no
approved these changes
Nov 20, 2024
Low Power mode can only be entered when there are no active DMA transfers. Move the Suspend and Resume processing to thread to allow waiting for the DMA available semaphore in USB Suspend handler. Signed-off-by: Tomasz Moń <tomasz.mon@nordicsemi.no>
DMA transfers do not execute when the USBD peripheral is in Low Power mode. Make sure that there is no DMA active transfer when entering Low Power mode and that new DMA transfers are not started when in Low Power mode because the transfer won't ever finish. Signed-off-by: Tomasz Moń <tomasz.mon@nordicsemi.no>
tmon-nordic
force-pushed
the
nrf-usbd-suspend
branch
from
86be527 to
77cd96f
Compare
anangl
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DMA transfers do not execute when the USBD peripheral is in Low Power mode. Make sure that there is no DMA active transfer when entering Low Power mode and that new DMA transfers are not started when in Low Power mode because the transfer won't ever finish.