Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers/flash: Correct flash_erase userspace handler #81778

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

de-nordic
Copy link
Collaborator

As the erase callback is optional, handler should not check if it is not NULL.

Fixes #81777

@de-nordic de-nordic self-assigned this Nov 22, 2024
@de-nordic de-nordic added backport v3.7-branch Request backport to the v3.7-branch backport v4.0-branch Backport to the v4.0-branch labels Nov 22, 2024
@de-nordic de-nordic added this to the v4.1.0 milestone Nov 22, 2024
@zephyrbot zephyrbot added area: Flash size: XS A PR changing only a single line of code labels Nov 22, 2024
@zephyrbot zephyrbot requested a review from rghaddab November 22, 2024 15:32
@de-nordic de-nordic added bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug labels Nov 22, 2024
@de-nordic de-nordic requested a review from nashif November 22, 2024 15:33
As the erase callback is optional, handler should not check
if it is not NULL.

Fixes zephyrproject-rtos#81777

Signed-off-by: Dominik Ermel <dominik.ermel@nordicsemi.no>
@kartben kartben merged commit 4864289 into zephyrproject-rtos:main Dec 19, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Flash backport v3.7-branch Request backport to the v3.7-branch backport v4.0-branch Backport to the v4.0-branch bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug size: XS A PR changing only a single line of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flash API: flash_erase has incorrect userspace handler
5 participants