ADC STM32: Various fixes and enhancements #82955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: ADC
zephyrbot
requested review from
anangl,
erwango,
FRASTM,
GeorgeCGV,
marwaiehm-st and
mathieuchopstm
gautierg-st
force-pushed
the
adc_overrun_and_other_fixes
branch
from
79f099b to
59f8450
Compare
erwango
reviewed
Dec 13, 2024
drivers/adc/adc_stm32.c
Outdated
| if (LL_ADC_IsActiveFlag_OVR(adc)) { | ||
| LL_ADC_ClearFlag_OVR(adc); | ||
| LOG_ERR("ADC overrun error occurred. Reduce clock source frequency, " | ||
| "increase prescaler value, or increase sampling times."); |
There was a problem hiding this comment.
Nitpick:
Suggested change
| "increase prescaler value, or increase sampling times."); | |
| "increase prescaler value or increase sampling times."); | |
Displays an error log message when an ADC overrun occurs. Signed-off-by: Guillaume Gautier <guillaume.gautier-ext@st.com>
STM32F3 and H7 have multiple ADC versions difficult to differentiate. Use clearer macros to make code more readable. Signed-off-by: Guillaume Gautier <guillaume.gautier-ext@st.com>
gautierg-st
force-pushed
the
adc_overrun_and_other_fixes
branch
from
59f8450 to
a21a2af
Compare
erwango
previously approved these changes
Dec 13, 2024
On STM32 ADC, there are currently two types of oversamplers (if present), one with 8 available oversampling values, the other with 1024. To simplify the driver, add the oversampler as a dts property. Also add defines to avoid magic values in the dtsi. Signed-off-by: Guillaume Gautier <guillaume.gautier-ext@st.com>
Add ADC oversampler type to all ADC of all series. Signed-off-by: Guillaume Gautier <guillaume.gautier-ext@st.com>
Use the new oversampler property to simplify the management of the ADC oversampling. Signed-off-by: Guillaume Gautier <guillaume.gautier-ext@st.com>
Remove specific cases for H7 and U5: group them together and only call a single function. ADC3 of H72x/H73x and ADC4 of U5 are different from other ADC of their series, and have dedicated functions in the LL for enabling DMA, but they're doing the exact same operation as LL_ADC_REG_SetDataTransferMode. Incidentally, this change allows H7A/H7B to use the DMA (it seems to have been missed before). Last, this change enables the DMA support for F1x ADC. Signed-off-by: Guillaume Gautier <guillaume.gautier-ext@st.com>
gautierg-st
force-pushed
the
adc_overrun_and_other_fixes
branch
from
c29a8b7 to
b50eed6
Compare
zephyrbot
requested review from
asm5878,
benothmn-st,
duda-patryk,
fabiobaltieri,
HoZHel and
keith-zephyr
|
Also applied string enum to st,adc-clock-source property that I missed earlier |
erwango
previously approved these changes
Dec 18, 2024
Adds an ADC DMA test for Nucleo F103RB board now that support for it is added in the ADC driver. Reading multiple channels in F1 is only possible with the DMA, hence the necessity to have a dedicated twister test for it. Signed-off-by: Guillaume Gautier <guillaume.gautier-ext@st.com>
STM32 sequencer property and clock source were defined using arbitrary numbers. Use string instead. Signed-off-by: Guillaume Gautier <guillaume.gautier-ext@st.com>
In all STM32 dtsi and board dts, update the st,adc-sequencer and the st,adc-clock-source properties so they are strings. Signed-off-by: Guillaume Gautier <guillaume.gautier-ext@st.com> fu dts: arm: st: use string instead of enum
…erty Now that st,adc-sequencer and st,adc_clock-source use a string, update the ADC driver. Signed-off-by: Guillaume Gautier <guillaume.gautier-ext@st.com> fu drv adc update driver with string
Now that clock source and sequencer are defined with strings in device tree, move the old defines directly in the driver Signed-off-by: Guillaume Gautier <guillaume.gautier-ext@st.com>
Listify the content of the tables used for sequencer and oversampling. Signed-off-by: Guillaume Gautier <guillaume.gautier-ext@st.com>
config->base is already defined as ADC_TypeDef so no there is no need to cast it as such. Remove all occurrences throughout the file. Signed-off-by: Guillaume Gautier <guillaume.gautier-ext@st.com>
gautierg-st
force-pushed
the
adc_overrun_and_other_fixes
branch
from
b50eed6 to
21eaef6
Compare
erwango
approved these changes
Dec 18, 2024
|
Could it be that there is an entry in the release notes/migration guide missing? Because changing the type of the properties to string is somewhat a breaking change. I just stumbled upon this. No big deal, but might be noteworthy in the documentation. |
+1. @gautierg-st please follow up on adding this to the migration guide. |
Done here #85643 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains various fixes and enhancements for the STM32 ADC driver:
Fixes #79909