[Backport v4.0-branch] dts: atmel: sam0: Clean up devicetree #83135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keep a consistent order on the nodes definitions to make it easy to read between all the SoC series. Signed-off-by: Gerson Fernando Budke <nandojve@gmail.com> (cherry picked from commit 6f1f598)
When running tests on sam0 platform was detected that pinctrl for ADC were not defined for some boards. To force an error at build time nodes should be explicity disabled. This explicity disable nodes on devicetree that require some user configuration. In addition, the adc feature were excluded in some boards and samr21-xpro was correct updated. Signed-off-by: Gerson Fernando Budke <nandojve@gmail.com> (cherry picked from commit 162f728)
Reorder and add missing aliases and chosen nodes. Signed-off-by: Gerson Fernando Budke <nandojve@gmail.com> (cherry picked from commit 748bbd0)
The DMA is already defined on the base header. This exclude the duplicated node. Signed-off-by: Gerson Fernando Budke <nandojve@gmail.com> (cherry picked from commit 2e7599e)
The saml2x series provide USB to all SoC series. This moves the USB node from saml21.dtsi to the base file saml2x.dtsi. Signed-off-by: Gerson Fernando Budke <nandojve@gmail.com> (cherry picked from commit 34fc01e)
The samr21 is a samd21 with a builtin at86rf233 radio. Use the samd21 as base for these SoC and drop all duplicated nodes. Signed-off-by: Gerson Fernando Budke <nandojve@gmail.com> (cherry picked from commit 01fc0a7)
zephyrbot
added
the
platform: Microchip SAM
zephyrbot
requested review from
attie-argentum,
mnkp,
pdgendt and
stephanosio
stephanosio
approved these changes
Dec 18, 2024
pdgendt
approved these changes
Dec 18, 2024
nandojve
approved these changes
Dec 18, 2024
|
#83148 is an enhancement. We usually only backport bug fixes. What's the rationale for backporting this? |
Due to heavily changes on dts I'm not sure if future fixes/backports will be easy/possible to backport without these changes. I just want to make sure future enhancements are easy to developers to backport. At end, this is a clean-up, I can create an issue to it too. |
henrikbrixandersen
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 01fc0a7~6..01fc0a7 from #82991.
Fixes #83148