os: fdtable: set offset to zero with newly reserved fd's #83484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if a file object is was re-used, it could inherit the offset field of the previously closed file object, making reading from the beginning of the file impossible until the offset was manually zero'ed. The offset should *always* be zero when a file is ready to be used. The issue really only presents itself when implementing a vtable backend. Signed-off-by: Chris Friedt <cfriedt@tenstorrent.com>
10 tasks
peter-mitsis
approved these changes
Jan 2, 2025
kartben
approved these changes
Jan 2, 2025
ubieda
approved these changes
Jan 2, 2025
ycsin
approved these changes
Jan 3, 2025
Member
Author
|
Changing assignees because I don't think this was properly assigned. |
jukkar
approved these changes
Jan 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a file object is is re-used, it could inherit the offset field of the previously closed file object, making reading from the beginning of the file impossible until the offset was manually zero'ed.
The offset should always be zero when a file is ready to be used.
The issue really only presents itself when implementing a vtable backend.