posix: options: remove default setting of toolchain option #83485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not set TC_PROVIDES_POSIX_C_LANG_SUPPORT_R as the default in lib/posix/options/Kconfig.c_lang_r . TC_PROVIDES options are only intended to be set by C libraries that implement parts of the POSIX standard. Signed-off-by: Chris Friedt <cfriedt@tenstorrent.com>
10 tasks
zephyrbot
added
size: XS
ycsin
approved these changes
Jan 2, 2025
ubieda
approved these changes
Jan 2, 2025
jukkar
approved these changes
Jan 3, 2025
cfriedt
deleted the
posix-options-remove-default-setting-of-toolchain-option
branch
Contributor
|
This broke CI in main and will need some follow-up/hotfix as it's also impacting CI on some PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not set TC_PROVIDES_POSIX_C_LANG_SUPPORT_R as the default in lib/posix/options/Kconfig.c_lang_r . TC_PROVIDES options are only intended to be set by external C libraries that implement parts of the POSIX standard so that multiple symbols aren't defined at link time.