shell: modules: kernel_service: deprecate log_level #83993
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdgendt
approved these changes
Jan 15, 2025
Log_level command is a duplicate of 'log enable' command from the logging command set (enabled by CONFIG_LOG_CMDS=y). Adding warning about deprecation as 'log enable' is recommended since it has more features (e.g. autocompletion). Signed-off-by: Krzysztof Chruściński <krzysztof.chruscinski@nordicsemi.no>
Contributor
|
@nordic-krch I think I would just drop it tbh, but otherwise I think you want to add a note to #80539 so that someone actually remembers to come back to it when it's time to actually remove it. |
jakub-uC
approved these changes
Jan 16, 2025
17 tasks
Contributor
Author
|
@kartben Added to the list for 4.3 deprecation. |
ycsin
approved these changes
Jan 16, 2025
Member
ycsin
left a comment
ycsin
left a comment
There was a problem hiding this comment.
I found this command out-of-place for kernel service when I refactor the code last time, so this change is much welcomed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log_level command is a duplicate of 'log enable' command from the logging command set (enabled by CONFIG_LOG_CMDS=y). Adding warning about deprecation as 'log enable' is recommended since it has more features (e.g. autocompletion).