Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers: flash: w25qxxdv: Avoid locking when not threaded #8450

Merged
merged 1 commit into from
Jun 18, 2018

Conversation

JoeHut
Copy link
Contributor

@JoeHut JoeHut commented Jun 18, 2018

When using CONFIG_MULTITHREADING=n, the semaphore primitives are
non-functional and useless. Remove their usage when this option is
enabled.

Signed-off-by: Johannes Hutter johannes@proglove.de

@JoeHut JoeHut requested a review from nashif as a code owner June 18, 2018 11:05
@JoeHut
Copy link
Contributor Author

JoeHut commented Jun 18, 2018

Similar to the changes in #8430. Related to the discussion in #8368

@codecov-io
Copy link

codecov-io commented Jun 18, 2018

Codecov Report

Merging #8450 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8450   +/-   ##
=======================================
  Coverage   64.61%   64.61%           
=======================================
  Files         421      421           
  Lines       40296    40296           
  Branches     6803     6803           
=======================================
  Hits        26037    26037           
  Misses      11126    11126           
  Partials     3133     3133

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bfc7ff...7262784. Read the comment docs.

When using CONFIG_MULTITHREADING=n, the semaphore primitives are
non-functional and useless. Remove their usage when this option is
enabled.

Signed-off-by: Johannes Hutter <johannes@proglove.de>
@JoeHut JoeHut force-pushed the w25q_flash_threads branch from 4e7f0f2 to 7262784 Compare June 18, 2018 12:10
@carlescufi carlescufi requested a review from tbursztyka June 18, 2018 12:38
@nashif nashif merged commit 392da5b into zephyrproject-rtos:master Jun 18, 2018
@JoeHut JoeHut deleted the w25q_flash_threads branch July 4, 2018 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants