picolibc: Add noexcept variant of libstdc++ #85945
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add PICOLIBC_LIBCXX_VARIANT config with two options: * PICOLIBC_LIBCXX_FULL - standard variant * PICOLIBC_LIBCXX_NOEXCEPT - variant compiled with `-fno-exceptions` * Link with `libstc++_noexcept` if variant is available in toolchain and CPP_EXCEPTIONS is disabled. Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
keith-packard
approved these changes
Feb 18, 2025
There was a problem hiding this comment.
This looks good now. You might take a look at my libstdc++ module proposal and see how these two interact. #80762
They should work fine together. I would just change the depend from |
|
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-fno-exceptionslibstc++_noexceptif variant is available in toolchain and CPP_EXCEPTIONS is disabled.