Bluetoth: Host: Fix buffer allocation warnings in system workqueue #86125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Bluetooth
area: Bluetooth Host
zephyrbot
requested review from
alwa-nordic,
cvinayak,
hermabe,
rugeGerritsen,
sjanc,
Thalley and
theob-pro
|
Hmm, seems like this is not sufficient to get rid of the warning. I get it e.g. with the shell when enabling advertising and connecting to it from my phone: So there's some other code path that's also passing a non-zero timeout. |
jhedberg
force-pushed
the
conn_sys_wq_block
branch
from
6c56f04 to
70f1e67
Compare
Now updated with another check in |
jhedberg
changed the title
Thalley
reviewed
Feb 21, 2025
The buffer allocation in conn.c will trigger warnings if we try to use anything else than K_NO_WAIT for the timeout when called from within the system workqueue. The calls in l2cap.c and att.c which may pass non-zero timeouts already have proper handling for failed allocations, so make sure we use K_NO_WAIT to avoid unnecessary warnings from conn.c. Signed-off-by: Johan Hedberg <johan.hedberg@silabs.com>
jhedberg
force-pushed
the
conn_sys_wq_block
branch
from
70f1e67 to
0f5f748
Compare
Thalley
approved these changes
Feb 21, 2025
cvinayak
approved these changes
Feb 21, 2025
alwa-nordic
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The buffer allocation in conn.c will trigger warnings if we try to use anything else than K_NO_WAIT for the timeout when called from within the system workqueue.
The calls in l2cap.c and att.c which may pass non-zero timeouts already have proper handling for failed allocations, so make sure we use K_NO_WAIT to avoid unnecessary warnings from conn.c.