USB STM32: correct compilation error for USB clean speed configuration #88152
Conversation
kbidani
force-pushed
the
fix_usb_clean_speed
branch
7 times, most recently
from
2cb412b to
33b1153
Compare
There was a problem hiding this comment.
For commit "drivers: usb: udc_stm32: fix maximum speed for usb_fs":
Note the CI test failing on commit message containing line > 74 chars. -> addressed
Since this fixes a previous commit, could you add a Fixes: tag in the commit message:
Fixes: ba1ad38f998d02d624e9d2f6d1605a5fbbdf44f1
For commit "drivers: usb: device_stm32: fix maximum speed for usb_f":
Fixes: 01ddccdf626a2d767d4b76b648fc9e520c35ded5
update the definition of FULL_SPEED based on the presence of USB and USB_DRD_FS. Signed-off-by: Khaoula Bidani <khaoula.bidani-ext@st.com>
update the definition of FULL_SPEED based on the presence of USB and USB_DRD_FS. Signed-off-by: Khaoula Bidani <khaoula.bidani-ext@st.com>
kbidani
force-pushed
the
fix_usb_clean_speed
branch
from
33b1153 to
f0217f9
Compare
github-actions
bot
added
platform: STM32
github-actions
bot
requested review from
FRASTM,
GeorgeCGV,
djiatsaf-st,
erwango,
gautierg-st,
jfischer-no,
marwaiehm-st,
mathieuchopstm and
tmon-nordic
kbidani
changed the title
fabiobaltieri
added
the
Trivial
jfischer-no
removed
the
Trivial
| #if DT_HAS_COMPAT_STATUS_OKAY(st_stm32_usb) | ||
| #define FULL_SPEED PCD_SPEED_FULL | ||
| #else | ||
| #define FULL_SPEED USB_OTG_SPEED_FULL | ||
| #endif |
There was a problem hiding this comment.
HIGH_SPEED/FULL_SPEED is a very bad choice. I see this was introduced in 01ddccd. No idea how this could get enough approvals and be merged. Not that there are no macros that are already prefixed correctly with UDC_STM32_.
There was a problem hiding this comment.
@jfischer-no so you are suggesting these should be renamed to UDC_STM32_FULL_SPEED and UDC_STM32_FULL_SPEED? Not super clear to me from your comment, trying to land this to an approvable state with few turnarounds since it break the build for load of platforms.
There was a problem hiding this comment.
There was a problem hiding this comment.
Thanks, I think it's fine to wait for a fix forward no need to rush a revert, just wanted to go straight to the right fix.
There was a problem hiding this comment.
Just revert #86922
Given that there's still no progress on this, I suggest we perform a revert. This is breaking downstream users/CI.
jfischer-no
left a comment
jfischer-no
left a comment
There was a problem hiding this comment.
drivers: usb: udc_stm32: fix maximum speed for usb_fs
What is usb_fs?
update the definition of FULL_SPEED based on the presence of USB
and USB_DRD_FS.
What does "presence of USB" mean?
|
See #88244 |
6 participants
This pull request fix the USB speed configuration by leveraging the device tree's status, ensuring the correct full-speed setting is applied dynamically.