drivers: stepper: Fix stepper callbacks when using work_q #88835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
bjarki-andreasen,
dipakgmx,
fabiobaltieri,
faxe1008,
jbehrensnx and
jilaypandya
jilaypandya
reviewed
Apr 20, 2025
tests/drivers/stepper/stepper_api/boards/native_sim_adi_tmc2209_work_q.overlay
Outdated
Show resolved
Hide resolved
tests/drivers/stepper/stepper_api/boards/native_sim_allegro_a4979_work_q.overlay
Outdated
Show resolved
Hide resolved
jilaypandya
reviewed
Apr 20, 2025
dipakgmx
reviewed
Apr 20, 2025
jbr7rr
force-pushed
the
fix-stepper-callbacks-when-using-work_q
branch
2 times, most recently
from
dfeb19e to
5d6dced
Compare
faxe1008
reviewed
Apr 22, 2025
How? Unit test and fix? |
Yep, the order would have to be fix and unit-test. Making 130 as a Kconfig could be added to the second commit as well :) |
Fix issue where stepper callbacks were not being called when using work_q. This was due to the steps being counted down before the work_q was rescheduled. Signed-off-by: Josselin Bunt <josselin@sensible.health>
This commit adds unit tests for the stepper API using work_q scheduler. Signed-off-by: Josselin Bunt <josselin@sensible.health>
jbr7rr
force-pushed
the
fix-stepper-callbacks-when-using-work_q
branch
from
5d6dced to
1893718
Compare
jilaypandya
approved these changes
May 3, 2025
bjarki-andreasen
approved these changes
May 3, 2025
faxe1008
approved these changes
May 3, 2025
dipakgmx
approved these changes
May 3, 2025
|
Hi @jbr7rr! To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge. Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁 |
jilaypandya
added a commit
to jilaypandya/zephyr
that referenced
this pull request
May 4, 2025
deleting two test-cases from drv8424 test-suite since these test-cases are now present in stepper-api since zephyrproject-rtos#88835 Signed-off-by: Jilay Pandya <jilay.pandya@outlook.com>
kartben
pushed a commit
that referenced
this pull request
May 5, 2025
deleting two test-cases from drv8424 test-suite since these test-cases are now present in stepper-api since #88835 Signed-off-by: Jilay Pandya <jilay.pandya@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue where stepper callbacks were not being called when using work_q. This was due to the steps being counted down before the work_q was rescheduled.
Added additional unit tests to stepper_api to verify the fix. Needed to increase the tolerance to 30% because of the timing of the work_q.
Fixes: #88821