Centralize net_mgmt layer code allocation #89083
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
MaochenWang1,
glarsennordic,
krish2718,
pdgendt,
rlubos,
ssharks and
tbursztyka
rlubos
previously approved these changes
Apr 25, 2025
jukkar
commented
Apr 25, 2025
jukkar
force-pushed
the
devel/net-mgmt-layer-codes
branch
from
c1d9f22 to
0bed9ac
Compare
Member
Author
|
pdgendt
previously approved these changes
Apr 25, 2025
rlubos
previously approved these changes
Apr 25, 2025
JordanYates
reviewed
Apr 25, 2025
include/zephyr/net/net_mgmt.h
Outdated
|
|
||
| /** @endcond */ | ||
|
|
||
| /** Central place the definition of the layer codes (7 bit value) */ |
Contributor
There was a problem hiding this comment.
Should the codes be an enum so they are grouped nicely in the docs and the whole group has this header?
Member
Author
There was a problem hiding this comment.
We can certainly experiment with enum, the current doc does not look that great atm https://builds.zephyrproject.io/zephyr/pr/89083/docs/doxygen/html/group__net__mgmt.html
I will mark this as DNM and investigate this more.
Instead of littering the source tree with hard to track layer code definitions, have a central place where to register the layer codes. Signed-off-by: Jukka Rissanen <jukka.rissanen@nordicsemi.no>
The _ is a reserved character in front of the symbols so remove it from network management event macros. The remaining string without the _ will identify the network API anyway so having underscore there is not needed. Signed-off-by: Jukka Rissanen <jukka.rissanen@nordicsemi.no>
Instead of hard coding some random value to layer code, use the code that is registered in net_mgmt.h This way it is easier to keep track of used layer codes in the future, and we also allow out-of-tree components a way to avoid allocating same layer code to in-tree-source code. Signed-off-by: Jukka Rissanen <jukka.rissanen@nordicsemi.no>
jukkar
force-pushed
the
devel/net-mgmt-layer-codes
branch
from
0bed9ac to
2e47301
Compare
Member
Author
|
Replaced layer code definitions by enum values to make documentation look better. |
pdgendt
approved these changes
Apr 28, 2025
rlubos
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Place
net_mgmtlayer codes in one central place inzephyr/include/net/net_mgmt.hso that we can keep track of their allocation and usage in the code. Note that I specified the layer code as 7 bit value, although currently the existing code uses 4 more bits. We can steal those bits in the future for some other purposes.This PR does not change functionality of the code in any way.