drivers: video: dcmi: fix DMA channel configuration #92018
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I do not know the internals of the STM32 HAL enough to tell if this is the right approach. |
github-actions
bot
requested review from
FRASTM,
GeorgeCGV,
djiatsaf-st,
erwango,
etienne-lms,
gautierg-st,
loicpoulain,
marwaiehm-st,
mathieuchopstm and
ngphibang
JarmouniA
reviewed
Jun 23, 2025
| hdma.Init.Mode = DMA_CIRCULAR; | ||
| hdma.Init.Priority = DMA_PRIORITY_HIGH; | ||
| #if defined(CONFIG_SOC_SERIES_STM32F7X) | ||
| #if defined(CONFIG_SOC_SERIES_STM32F7X) || defined(CONFIG_SOC_SERIES_STM32H7X) |
There was a problem hiding this comment.
I think the filtering should be done by DMA compatible instead of series.
There was a problem hiding this comment.
Yes, it sounds like this would avoid forgetting platforms accidentally.
There was a problem hiding this comment.
Is it suitable to keep the current bugfix and follow-up with this issue to avoid a change just before the release?
Commit 64149e4 added an "#if defined()" for configuring DMA channels differently depending on SOC family of the STM32 HAL, but did not include the STM32H7 family in the same group as STM32F7. Fix it by adding the STM32H7 in the same #ifdef filter. Fixes zephyrproject-rtos#92015 Signed-off-by: Josuah Demangeon <me@josuah.net>
|
|
Force-push:
|
kartben
approved these changes
Jun 27, 2025
JarmouniA
approved these changes
Jun 27, 2025
erwango
approved these changes
Jun 27, 2025
avolmat-st
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 64149e4 added an
#if defined()for configuring DMA channels differently depending on SOC family of the STM32 HAL, but did not include the STM32H7 family in the same group as STM32F7. Fix it by adding the STM32H7 in the same#ifdeffilter.Fixes #92015