Skip to content

cmake: clang: Enable -Waddress-of-packed-member #92322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2025
Merged

cmake: clang: Enable -Waddress-of-packed-member #92322

merged 1 commit into from
Jun 27, 2025

Conversation

@carlescufi
Copy link
Member

Several years ago we started enabling the -Waddress-of-packed-member warning in commit cf11196 for GCC.

Do the same for Clang, since there is no reason not to and the warning is very useful, especially in protocol stacks.

@carlescufi
cmake: clang: Enable -Waddress-of-packed-member
f32c778 
Several years ago we started enabling the -Waddress-of-packed-member
warning in commit cf11196 for GCC.

Do the same for Clang, since there is no reason not to and the warning
is very useful, especially in protocol stacks.

Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
@carlescufi carlescufi mentioned this pull request Jun 27, 2025
Closed
@github-actions github-actions bot added size: XS A PR changing only a single line of code area: Build System area: Toolchains Toolchains labels Jun 27, 2025
@carlescufi carlescufi added the Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc. label Jun 27, 2025
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@danieldegrasse danieldegrasse merged commit 4ea89d0 into zephyrproject-rtos:main Jun 27, 2025
30 checks passed
@aescolar
Copy link
Member

aescolar commented Jul 1, 2025 •
edited
Loading

@carlescufi note this PR causes this warning to trigger in main, so main CI is failing since it got merged:
https://github.com/zephyrproject-rtos/zephyr/actions/runs/15938996364/job/44964173813#step:11:484
Which can be repro'd with:
ZEPHYR_TOOLCHAIN_VARIANT=llvm twister -p native_sim -s drivers.ieee802154.build.external -T tests/drivers/build_all/ieee802154
ZEPHYR_TOOLCHAIN_VARIANT=llvm twister -p native_sim -s net.hostname.event -T tests/net/hostname

@aescolar
Copy link
Member

aescolar commented Jul 1, 2025 •
edited
Loading

possible fix in here: #92459

@danieldegrasse
Copy link
Contributor

possible fix in here: #92459

Thanks for taking a look at this- also been trying to hunt these down (in hindsight, we probably should have held this until after 4.2...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tpambor tpambor tpambor approved these changes

@dkalowsk dkalowsk dkalowsk approved these changes

@tejlmand tejlmand tejlmand approved these changes

@stephanosio stephanosio stephanosio approved these changes

@JarmouniA JarmouniA JarmouniA approved these changes

@57300 57300 Awaiting requested review from 57300

@jeremybettis jeremybettis Awaiting requested review from jeremybettis

@nashif nashif Awaiting requested review from nashif

@nordicjm nordicjm Awaiting requested review from nordicjm

Assignees

@tejlmand tejlmand

Labels

area: Build System area: Toolchains Toolchains size: XS A PR changing only a single line of code Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@carlescufi @aescolar @danieldegrasse @tpambor @dkalowsk @tejlmand @stephanosio @JarmouniA