Skip to content

Conversation

@mariopaja
Copy link
Contributor

Use DMA defines to describe SAI DMA configuration on STM32U5xx & STM32H5xx series
Although the DMA defines are not used to configure the SAI DMA, they give an overview over its configuration

Use DMA defines to describe SAI DMA configuration.

Signed-off-by: Mario Paja <mariopaja@hotmail.com>
@sonarqubecloud
Copy link

Copy link
Contributor

@evgeniy-paltsev evgeniy-paltsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the DMA defines are not used to configure the SAI DMA, they give an overview over its configuration

Nitpick - it worth to at least mention it in dts/bindings/i2s/st,stm32-sai.yaml (i.e. in dmas property description)

Although changing most of the dma configuration doesn't make sense for SAI, changing of STM32_DMA_PRIORITY_HIGH to other priority looks legit. So, as we don't support it, let's add explicit mention of that.

@mariopaja
Copy link
Contributor Author

Hi @evgeniy-paltsev

Although changing most of the dma configuration doesn't make sense for SAI, changing of STM32_DMA_PRIORITY_HIGH to other priority looks legit.

Lets leave this as it is. I will write it down and open another PR for that 😃

@kartben kartben merged commit 82ea32b into zephyrproject-rtos:main Aug 22, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

platform: STM32 ST Micro STM32

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants