dts: st: stm32h7rs: Add fdcan1 and fdcan2 configuration #95388
Conversation
|
Hello @TD-JBL, and thank you very much for your first pull request to the Zephyr project! |
zephyrbot
requested review from
FRASTM,
GeorgeCGV,
djiatsaf-st,
erwango,
etienne-lms,
gautierg-st,
marwaiehm-st and
mathieuchopstm
etienne-lms
left a comment
etienne-lms
left a comment
There was a problem hiding this comment.
For consistency in commits header lines in the Git revisions history, could your change it:
-dts: st: stm32h7rs: Add fdcan1 and fdcan2 configuration
+dts: arm: st: h7rs: Add fdcan1 and fdcan2 configuration 
erwango
left a comment
erwango
left a comment
There was a problem hiding this comment.
Please enable the node at board level so we have a way to test it in CI
The NUCLEO-H7S3L8 does not have a CAN transceiver onboard. Is it useful to enable CAN on some random pins on the breakout headers for this board? The bigger STM32H7S78-DK also does not have a CAN receiver. I'm not aware of other H7RSx boards. |
Indeed, CAN transceivers are generally missing, but yet it could be enabled on board to run basic driver initialization. See other STM32 boards with CAN enabled for reference: https://docs.zephyrproject.org/latest/boards/index.html#vendor=st&features=can |
etienne-lms
left a comment
etienne-lms
left a comment
There was a problem hiding this comment.
For commit "boards: arm: st: nucleo_h7s3l8: Add fdcan1":
Could you break lines (74char/line) in the commit message body?
TD-JBL
force-pushed
the
h7rs_fdcan
branch
2 times, most recently
from
7b38bb4 to
4ef43b1
Compare
Sure, I thought the 74 char limit was only for the first line, already fixed. And thanks for catching my repeating copy'n'paste |
|
In case it helps, you can |
| clocks = <&rcc STM32_CLOCK(APB1_2, 8)>, | ||
| <&rcc STM32_SRC_HSE FDCAN_SEL(0)>; |
There was a problem hiding this comment.
Non blocking: Adding clocks here is optional, but it could be clearer to keep it indeed.
Provide the soc configuration for fdcan1 and fdcan2 controllers. This includes registers address, clocks and interrupt lines details. Signed-off-by: Thomas Decker <decker@jb-lighting.de>
Enable support for FDCAN1 on nucleo_h7s3l8 board. PD0 (RX) and PD1 (TX) are used for interfacing an external CAN transceiver according to the breakout connector description in the board's schematic. Signed-off-by: Thomas Decker <decker@jb-lighting.de>
|
Fix wrong heading type in index.rst introduced with PR zephyrproject-rtos#95388 Signed-off-by: Thomas Decker <decker@jb-lighting.de>
Fix wrong heading type in index.rst introduced with PR zephyrproject-rtos#95388 Signed-off-by: Thomas Decker <decker@jb-lighting.de>
Fix wrong heading type in index.rst introduced with PR zephyrproject-rtos#95388 Signed-off-by: Thomas Decker <decker@jb-lighting.de>
Fix wrong heading type in index.rst introduced with PR #95388 Signed-off-by: Thomas Decker <decker@jb-lighting.de>
Fix wrong heading type in index.rst introduced with PR zephyrproject-rtos#95388 Signed-off-by: Thomas Decker <decker@jb-lighting.de>
5 participants
This PR adds FDCAN support for STM32H7RS series microcontrollers.
As the H7RSx doesn't have the clock calibration unit (CCU) inside the FDCAN peripheral and a different message RAM size compared to H7x, I took the H5x configuration as template for this change. According to the reference manuals, the FDCAN peripheral is the same (except for register addresses, clock source and interrupt numbers).
Changes:
SoC support: Add FDCAN1 and FDCAN2 controller configurations for STM32H7RS series
Clock Configuration:
I added the second (optional) clock to the configuration (called domain clock in the driver), even if the HSE is already the default clock source. But programmers can then see more quickly how they can adjust the clock source.
Testing Status: