Skip to content

Removed CPU0 from MCXW72 devices as only one CPU should be targeted. #95684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Removed CPU0 from MCXW72 devices as only one CPU should be targeted. #95684

wants to merge 1 commit into from
+23 −35

Conversation

@EmilioCBen
Copy link
Contributor

@EmilioCBen EmilioCBen commented Sep 8, 2025 •
edited by dleach02
Loading

Removed CPU0 from MCXW72 devices as only one CPU should be targeted.

@EmilioCBen EmilioCBen added the Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc. label Sep 8, 2025
@zephyrbot zephyrbot added area: Counter area: I2C platform: NXP Drivers NXP Semiconductors, drivers area: SPI SPI bus area: ADC Analog-to-Digital Converter (ADC) area: PWM Pulse Width Modulation platform: NXP NXP labels Sep 8, 2025
decsny
decsny requested changes Sep 8, 2025
View reviewed changes
Copy link
Member

@decsny decsny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to squash the commits to be bisectable

@EmilioCBen EmilioCBen force-pushed the fix/mcxw72_dual_cpu_correction branch 2 times, most recently from 70c0add to a533c5b Compare September 8, 2025 20:57
@zephyrbot zephyrbot added the area: Watchdog Watchdog label Sep 8, 2025
decsny
decsny previously approved these changes Sep 8, 2025
View reviewed changes
@EmilioCBen EmilioCBen force-pushed the fix/mcxw72_dual_cpu_correction branch 2 times, most recently from 6070bc7 to 0c5f809 Compare September 9, 2025 16:42
@teburd teburd removed their request for review September 9, 2025 17:26
decsny
decsny previously approved these changes Sep 9, 2025
View reviewed changes
@butok
Copy link
Contributor

butok commented Sep 11, 2025

Is there no need to have a possibility to build/flash for the second core?

@decsny
Copy link
Member

decsny commented Sep 11, 2025 •
edited
Loading

Is there no need to have a possibility to build/flash for the second core?

This nbu core is only meant to be running signed NXP radio firmwares, adding soc kconfigs like this about a "cpu1" (or an implication by calling the user programmable core "cpu0") to zephyr was an accident.

mmahadevan108
mmahadevan108 previously approved these changes Sep 12, 2025
View reviewed changes
@mmahadevan108
Copy link
Contributor

@EmilioCBen , please resolve the merge conflict

@EmilioCBen EmilioCBen dismissed stale reviews from mmahadevan108 and decsny via 8070c3b September 15, 2025 14:30
@EmilioCBen EmilioCBen force-pushed the fix/mcxw72_dual_cpu_correction branch from 0c5f809 to 8070c3b Compare September 15, 2025 14:30
@zephyrbot zephyrbot requested a review from rlubos September 15, 2025 14:34
@EmilioCBen EmilioCBen force-pushed the fix/mcxw72_dual_cpu_correction branch from 8070c3b to c3b73dc Compare September 18, 2025 14:46
@EmilioCBen EmilioCBen force-pushed the fix/mcxw72_dual_cpu_correction branch from c3b73dc to 76207cf Compare September 18, 2025 15:09
@EmilioCBen
Copy link
Contributor Author

EmilioCBen commented Sep 18, 2025 •
edited
Loading

Depends on #91869 Due to DMA Cells needed in LPUART Nodes for uart_async_api test to pass twister.

@EmilioCBen EmilioCBen added the DNM This PR should not be merged (Do Not Merge) label Sep 18, 2025
@decsny decsny removed the DNM This PR should not be merged (Do Not Merge) label Sep 18, 2025
@decsny
Copy link
Member

decsny commented Sep 18, 2025 •
edited
Loading

you don't need to put DNM because of a CI fail, it already cant merge if CI fails.

@EmilioCBen
Copy link
Contributor Author

EmilioCBen commented Sep 18, 2025 •
edited
Loading

I put it for context and as an extra precaution for the PR not to be merged. Plus to maybe save some people time who are reviewing PRs.

@dleach02
Copy link
Member

PR #96308 will fix CI issue

@decsny
Copy link
Member

decsny commented Sep 23, 2025

@EmilioCBen I think you need to rebase to get latest main fixes for CI

@EmilioCBen
boards: nxp: removing cpu0 from mcxw72
c04a092 
Removing cpu0 reference from mcxw72 target
as only cpu0 should be targeted on this device.

Signed-off-by: Emilio Benavente <emilio.benavente@nxp.com>
@EmilioCBen EmilioCBen force-pushed the fix/mcxw72_dual_cpu_correction branch from 76207cf to c04a092 Compare September 30, 2025 14:53
@zephyrbot zephyrbot requested a review from nashif September 30, 2025 14:55
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@decsny decsny decsny left review comments

@anangl anangl Awaiting requested review from anangl

@axelnxp axelnxp Awaiting requested review from axelnxp

@butok butok Awaiting requested review from butok

@DerekSnell DerekSnell Awaiting requested review from DerekSnell

@dleach02 dleach02 Awaiting requested review from dleach02

@George-Stefan George-Stefan Awaiting requested review from George-Stefan

@henrikbrixandersen henrikbrixandersen Awaiting requested review from henrikbrixandersen

@MaochenWang1 MaochenWang1 Awaiting requested review from MaochenWang1

@nordic-krch nordic-krch Awaiting requested review from nordic-krch

@tbursztyka tbursztyka Awaiting requested review from tbursztyka

@katsuster katsuster Awaiting requested review from katsuster

@martinjaeger martinjaeger Awaiting requested review from martinjaeger

@rlubos rlubos Awaiting requested review from rlubos

@jukkar jukkar Awaiting requested review from jukkar

@kartben kartben Awaiting requested review from kartben

@mmahadevan108 mmahadevan108 Awaiting requested review from mmahadevan108

@teburd teburd Awaiting requested review from teburd

@nashif nashif Awaiting requested review from nashif

At least 2 approving reviews are required to merge this pull request.

Assignees

@mmahadevan108 mmahadevan108

@dleach02 dleach02

Labels

area: ADC Analog-to-Digital Converter (ADC) area: Counter area: I2C area: PWM Pulse Width Modulation area: SPI SPI bus area: Watchdog Watchdog platform: NXP Drivers NXP Semiconductors, drivers platform: NXP NXP Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@EmilioCBen @butok @decsny @mmahadevan108 @dleach02 @teburd @zephyrbot