Skip to content

ztest: Add validation of zassert strings #96335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 2, 2025
Merged

ztest: Add validation of zassert strings #96335

merged 3 commits into from
Oct 2, 2025
+14 −11

Conversation

tpambor
Copy link
Contributor

@tpambor tpambor commented Sep 21, 2025 •
edited
Loading

Add __printf_like attribute to ztest assertion functions zassert, zassume, zexpect to validate format strings and arguments at compile time.

This also fixes the following warnings when compiling with clang (found while testing new zephyr sdk 0.18.0-alpha4):

zephyr/subsys/testsuite/ztest/include/zephyr/ztest_assert.h:88:11: error: format string is not a string literal [-Werror,-Wformat-nonliteral]
   88 |                 vprintk(msg, vargs);
      |                         ^~~
zephyr/subsys/testsuite/ztest/include/zephyr/ztest_assert.h:112:11: error: format string is not a string literal [-Werror,-Wformat-nonliteral]
  112 |                 vprintk(msg, vargs);
      |                         ^~~
zephyr/subsys/testsuite/ztest/include/zephyr/ztest_assert.h:136:11: error: format string is not a string literal [-Werror,-Wformat-nonliteral]
  136 |                 vprintk(msg, vargs);
      |                         ^~~

@tpambor
ztest: Add validation of zassert strings
71d21f0 
Add __printf_like attribute to ztest assertion functions
zassert, zassume, zexpect to validate format strings and arguments
at compile time.

Signed-off-by: Tim Pambor <tim.pambor@codewrights.de>
@zephyrbot zephyrbot added the area: Testsuite Testsuite label Sep 21, 2025
@tpambor
tests: zdsp: Correct format specifier in assert_strings
a2b8c98 
strlen returns size_t, not int. Fix the format specifier to avoid warnings
when building with -Wformat.

Signed-off-by: Tim Pambor <tim.pambor@codewrights.de>
@tpambor
tests: ram_context_for_isr: fix format specifier for addresses
5184fd5 
Use %lx for printing addresses (uintptr_t) instead of %x.

Signed-off-by: Tim Pambor <tim.pambor@codewrights.de>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@jhedberg jhedberg merged commit e213815 into zephyrproject-rtos:main Oct 2, 2025
32 checks passed
This was referenced Oct 2, 2025
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nashif nashif nashif approved these changes

@pdgendt pdgendt pdgendt approved these changes

@aaronemassey aaronemassey Awaiting requested review from aaronemassey

@asemjonovs asemjonovs Awaiting requested review from asemjonovs

@jeremybettis jeremybettis Awaiting requested review from jeremybettis

@yperess yperess Awaiting requested review from yperess

@57300 57300 Awaiting requested review from 57300

@nordicjm nordicjm Awaiting requested review from nordicjm

@stephanosio stephanosio Awaiting requested review from stephanosio

@tejlmand tejlmand Awaiting requested review from tejlmand

Assignees

@nashif nashif

Labels

area: Build System area: DSP area: Testsuite Testsuite

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tpambor @nashif @pdgendt @jhedberg @zephyrbot