Skip to content

native_sim drivers: Set O_CLOEXEC for all native sim specific host descriptors by default #96806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 2, 2025
Merged

native_sim drivers: Set O_CLOEXEC for all native sim specific host descriptors by default #96806

merged 10 commits into from
Oct 2, 2025

Conversation

aescolar
Copy link
Member

@aescolar aescolar commented Sep 30, 2025 •
edited
Loading

If the process does an exec() (or fork, or..) all descriptors are kept
open by default and inherited by the child/replacement process,
unless O_CLOEXEC is set when opening them.
This is useful for stdin/out/err so that new process is connected to
them, but it is very rare for it to be useful for any other descriptor.

In general this leads to descriptors being kept open unnecessarily,
which either will block other process from connecting to the respective resource
(for example if the child survives the parent but it does something else).
Or for a "leak" which unnecessarily uses descriptors and memory in the
child process.

Let's ensure we do not leak it for all these components as we do not need it.

& as a freebie, fix driver table entry in native_sim docs

Note: If any of the reviewers would like the change to their area in a separate PR please just tell.
Otherwise I would still like to have an approval from each respective maintainer before merging.

@aescolar
docs native_sim: Fix drivers table entry for hwinfo
3b94a00 
A column was missing

Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
@aescolar
drivers can_native_linux: Set socket to be closed on exec
546c420 
If the process does an exec() (or fork, or..) all descriptors are kept
open by default, unless O_CLOEXEC is set for them.
(This default behaviour is usefull for stdin/out/err so that new process
is kept connected to them, but it is very rare for it to be usefull for
any other descriptor)

In general this leads to descriptors being kept open unnecessarily,
which either will block other process from using them (for example
if the child survives the parent but it does something else while keeping
a port open).
Or for a "leak" which unnecessarily uses descriptors and memory in the
child process.

Let's ensure we do not leak it for this component as we do not need it.

Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
@aescolar
drivers eeprom_simulator_native: Set EEPROM file to close on exec
0b6005f 
If the process does an exec() (or fork, or..) all descriptors are kept
open by default, unless O_CLOEXEC is set when opening them.
This is usefull for stdin/out/err so that new process is connected to
them, but it is very rare for it to be usefull for any other descriptor.

In general this leads to descriptors being kept open unnecessarily,
which either will block other process from getting them (for example
if the child survives the parent but it does something else).
Or for a "leak" which unnecessarily uses descriptors and memory in the
child process.

Let's ensure we do not leak it for this component as we do not need it.

Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
@aescolar
drivers eth_native_tap: Set socket to be closed on exec
65968aa 
If the process does an exec() (or fork, or..) all descriptors are kept
open by default, unless O_CLOEXEC is set when opening them.
This is usefull for stdin/out/err so that new process is connected to
them, but it is very rare for it to be usefull for any other descriptor.

In general this leads to descriptors being kept open unnecessarily,
which either will block other process from getting them (for example
if the child survives the parent but it does something else).
Or for a "leak" which unnecessarily uses descriptors and memory in the
child process.

Let's ensure we do not leak it for this component as we do not need it.

Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
@aescolar
drivers flash_simulator_native: Set flash file to close on exec
8d9574b 
If the process does an exec() (or fork, or..) all descriptors are kept
open by default, unless O_CLOEXEC is set when opening them.
This is usefull for stdin/out/err so that new process is connected to
them, but it is very rare for it to be usefull for any other descriptor.

In general this leads to descriptors being kept open unnecessarily,
which either will block other process from getting them (for example
if the child survives the parent but it does something else).
Or for a "leak" which unnecessarily uses descriptors and memory in the
child process.

Let's ensure we do not leak it for this component as we do not need it.

Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
@aescolar
drivers/input/linux_evdev: Close input file on exec
207fdf8 
If the process does an exec() (or fork, or..) all descriptors are kept
open by default, unless O_CLOEXEC is set when opening them.
This is usefull for stdin/out/err so that new process is connected to
them, but it is very rare for it to be usefull for any other descriptor.

In general this leads to descriptors being kept open unnecessarily,
which either will block other process from getting them (for example
if the child survives the parent but it does something else).
Or for a "leak" which unnecessarily uses descriptors and memory in the
child process.

Let's ensure we do not leak it for this component as we do not need it.

Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
@aescolar
drivers/net/nsos: Set socket to be closed on exec
c582628 
If the process does an exec() (or fork, or..) all descriptors are kept
open by default, unless O_CLOEXEC is set when opening them.
This is usefull for stdin/out/err so that new process is connected to
them, but it is very rare for it to be usefull for any other descriptor.

In general this leads to descriptors being kept open unnecessarily,
which either will block other process from getting them (for example
if the child survives the parent but it does something else).
Or for a "leak" which unnecessarily uses descriptors and memory in the
child process.

Let's ensure we do not leak it for this component as we do not need it.

Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
@aescolar
drivers/serial/uart_native_pty: Set PTY to be closed on exec
bab9293 
If the process does an exec() (or fork, or..) all descriptors are kept
open by default, unless O_CLOEXEC is set when opening them.
This is usefull for stdin/out/err so that new process is connected to
them, but it is very rare for it to be usefull for any other descriptor.

In general this leads to descriptors being kept open unnecessarily,
which either will block other process from getting them (for example
if the child survives the parent but it does something else).
Or for a "leak" which unnecessarily uses descriptors and memory in the
child process.

Let's ensure we do not leak it for this component as we do not need it.

Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
@aescolar
drivers/serial/uart_native_tty: Set TTY to be closed on exec
75f9d5f 
If the process does an exec() (or fork, or..) all descriptors are kept
open by default, unless O_CLOEXEC is set when opening them.
This is usefull for stdin/out/err so that new process is connected to
them, but it is very rare for it to be usefull for any other descriptor.

In general this leads to descriptors being kept open unnecessarily,
which either will block other process from getting them (for example
if the child survives the parent but it does something else).
Or for a "leak" which unnecessarily uses descriptors and memory in the
child process.

Let's ensure we do not leak it for this component as we do not need it.

Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
@aescolar
subsys/tracing/tracing_backend_posix: Set file to be closed on exec
3e639f9 
If the process does an exec() (or fork, or..) all descriptors are kept
open by default, unless O_CLOEXEC is set when opening them.
This is usefull for stdin/out/err so that new process is connected to
them, but it is very rare for it to be usefull for any other descriptor.

In general this leads to descriptors being kept open unnecessarily,
which either will block other process from getting them (for example
if the child survives the parent but it does something else).
Or for a "leak" which unnecessarily uses descriptors and memory in the
child process.

Let's ensure we do not leak it for this component as we do not need it.

Note glibc fopen supports the "e" modifier as an extension to pass
O_CLOEXEC to the open syscall.

Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
@aescolar aescolar changed the title O cloexec native_sim drivers: Set O_CLOEXEC for all native sim specific host descriptors by default Sep 30, 2025
@aescolar aescolar mentioned this pull request Sep 30, 2025
Closed
1 task
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@aescolar aescolar mentioned this pull request Sep 30, 2025
Merged
@aescolar aescolar marked this pull request as ready for review September 30, 2025 16:16
@kartben kartben merged commit 896bdce into zephyrproject-rtos:main Oct 2, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabiobaltieri fabiobaltieri fabiobaltieri approved these changes

@henrikbrixandersen henrikbrixandersen henrikbrixandersen approved these changes

@jukkar jukkar jukkar approved these changes

@tpambor tpambor tpambor approved these changes

@dcpleung dcpleung dcpleung approved these changes

@de-nordic de-nordic de-nordic approved these changes

@maass-hamburg maass-hamburg maass-hamburg approved these changes

@alexanderwachter alexanderwachter Awaiting requested review from alexanderwachter

@ClaCodes ClaCodes Awaiting requested review from ClaCodes

@decsny decsny Awaiting requested review from decsny

@lmajewski lmajewski Awaiting requested review from lmajewski

@martinjaeger martinjaeger Awaiting requested review from martinjaeger

@pdgendt pdgendt Awaiting requested review from pdgendt

@rghaddab rghaddab Awaiting requested review from rghaddab

@rlubos rlubos Awaiting requested review from rlubos

@str4t0m str4t0m Awaiting requested review from str4t0m

Assignees

@dcpleung dcpleung

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@aescolar @fabiobaltieri @henrikbrixandersen @jukkar @tpambor @dcpleung @de-nordic @maass-hamburg @kartben