net: socket: Change socklen_t to be 4 bytes long #96903
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Networking
size: XS
|
Discussion about the issue is here #96815 |
pdgendt
previously approved these changes
Oct 2, 2025
|
CI isn't happy with this change.. |
There is an issue when zephyr is compiled with native_sim_64 where size_t is 8 bytes. The socklen_t in specified as 4 bytes in Linux even for 64 bit builds so we have a conflict between Linux and Zephyr. To make things work properly, define socklen_t as uint32_t in order to align with Linux. Four bytes is enough for socket address length anyway. Signed-off-by: Jukka Rissanen <jukka.rissanen@nordicsemi.no>
jukkar
force-pushed
the
fix/socklen_t_type
branch
from
4f74b4c to
9e5f175
Compare
zephyrbot
added
area: Sockets
rlubos
previously approved these changes
Oct 2, 2025
pdgendt
previously approved these changes
Oct 2, 2025
|
This does modify public APIs, do we need some notes? |
The various socket option APIs in |
Add information that the socklen_t was changed from size_t, which can be either 32 or 64 bit long depending on system configuration, to always be 32 bit long. This is now aligned to way Linux is defining socklen_t. Signed-off-by: Jukka Rissanen <jukka.rissanen@nordicsemi.no>
There was extra parameter when calling zassert_ok() which caused compilation warning. Signed-off-by: Jukka Rissanen <jukka.rissanen@nordicsemi.no>
There was extra parameter when calling zassert_not_equal() which caused compilation warning. Signed-off-by: Jukka Rissanen <jukka.rissanen@nordicsemi.no>
Printing long int requires %ld when priting error. Signed-off-by: Jukka Rissanen <jukka.rissanen@nordicsemi.no>
jukkar
force-pushed
the
fix/socklen_t_type
branch
from
8555b65 to
2f3628a
Compare
|
pdgendt
approved these changes
Oct 2, 2025
rlubos
approved these changes
Oct 2, 2025
|
cfriedt
approved these changes
Oct 2, 2025
jhedberg
approved these changes
Oct 3, 2025
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue when zephyr is compiled with native_sim_64 where size_t is 8 bytes. The socklen_t in specified as 4 bytes in Linux even for 64 bit builds so we have a conflict between Linux and Zephyr. To make things work properly, define socklen_t as uint32_t in order to align with Linux. Four bytes is enough for socket address length anyway.