arch/riscv: Refactor PMP configuration reading #97084
Open
+31
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
edersondisouza,
fkokosinski,
katsuster,
kgugala,
masz-nordic,
mgielda,
npitre,
tgorochowik,
VynDragon and
ycsin
fsammoura1980
force-pushed
the
pmpcfg_helpers
branch
2 times, most recently
from
a60b606 to
416a805
Compare
Factor out the logic for reading PMP configuration registers (pmpcfgX) from dump_pmp_regs into a new static inline helper function, z_riscv_pmp_read_config. This new function encapsulates the architecture-specific (RV32/RV64) and slot-count-specific reads of the pmpcfg CSRs, improving code organization and potential reusability. Signed-off-by: Firas Sammoura <fsammoura@google.com>
fsammoura1980
force-pushed
the
pmpcfg_helpers
branch
from
416a805 to
7429405
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factor out the logic for reading PMP configuration registers (pmpcfgX) from dump_pmp_regs into a new static inline helper function, z_riscv_pmp_read_config.
This new function encapsulates the architecture-specific (RV32/RV64) and slot-count-specific reads of the pmpcfg CSRs, improving code organization and potential reusability.