bluetooth: hci: userchan: Improve RX allocation handling #97091
Conversation
zephyrbot
requested review from
alwa-nordic,
cvinayak,
HaavardRei,
hermabe,
HoZHel,
jhedberg,
PavelVPV and
Thalley
drivers/bluetooth/hci/userchan.c
Outdated
| struct net_buf *buf; | ||
|
|
||
| do { | ||
| buf = bt_buf_get_evt(data[1], discardable, discardable ? K_NO_WAIT : K_SECONDS(10)); |
There was a problem hiding this comment.
10 seconds sounds like a long time. If the event is e.g. a command status/complete you'll trigger an assert in the host since that's how long it waits for HCI commands. I'd make this lower, perhaps just 1 second, and also make it configurable through Kconfig, i.e. a subordinate option depending on the userchan option.
There was a problem hiding this comment.
note that this is in loop, so it behaves like K_FORVER anyway
but I can make it shorter (10 seconds was used simply because it is like that in IPC driver)
sjanc
force-pushed
the
user_channel_no_wait
branch
from
9966fa7 to
6ce7a92
Compare
Those flexible arrays allow for easy access to event data. Signed-off-by: Szymon Janc <szymon.janc@codecoup.pl>
sjanc
force-pushed
the
user_channel_no_wait
branch
from
6ce7a92 to
f0492fa
Compare
sjanc
force-pushed
the
user_channel_no_wait
branch
from
f0492fa to
94ef843
Compare
drivers/bluetooth/hci/userchan.c
Outdated
| uint8_t evt_type = evt_data[0]; | ||
|
|
||
| switch (evt_type) { | ||
| switch (ev->evt) { |
There was a problem hiding this comment.
Was ev chosen to avoid evt->evt? :)
sjanc
force-pushed
the
user_channel_no_wait
branch
from
94ef843 to
74f5d28
Compare
This makes userchan transport behavior similar to other HCI transports (eg IPC). Improved logging gives clear overview of what RX events are discarded helping for configuration tuning. Signed-off-by: Szymon Janc <szymon.janc@codecoup.pl>
sjanc
force-pushed
the
user_channel_no_wait
branch
from
74f5d28 to
4e2b5ee
Compare
|
This makes userchan transport behavior similar to other HCI transports (eg IPC). Improved logging gives clear overview of what RX events are discarded helping for configuration tuning.