tests: libc: thread: fix -Wformat errors #97202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
size: XS
zephyrbot
requested review from
aescolar,
cfriedt,
keith-packard,
nashif and
stephanosio
This was referenced Oct 8, 2025
aescolar
reviewed
Oct 8, 2025
tests/lib/c_lib/thrd/src/thrd.c
Outdated
| @@ -79,7 +79,7 @@ ZTEST(libc_thrd, test_thrd_create_join) | |||
|
|
|||
| zassert_equal(thrd_success, thrd_create(&thr, fun, ¶m)); | |||
| zassert_equal(thrd_success, thrd_join(thr, &res)); | |||
| zassert_equal(BIOS_FOOD, param, "expected: %d actual: %d", BIOS_FOOD, param); | |||
| zassert_equal(BIOS_FOOD, param, "expected: %u actual: %llu", BIOS_FOOD, (uint64_t)param); | |||
There was a problem hiding this comment.
Being pedantic
either cast to unsigned long long int and use that llu specifier
or to uin64_t and use PRIu64
There was a problem hiding this comment.
I changed it to unsigned long long
tpambor
force-pushed
the
c11-thread-zassert
branch
2 times, most recently
from
f7dd1d3 to
caca6aa
Compare
Cast uintptr_t to unsigned long long and adjust format specifier accordingly to ensure compatibility on both 32-bit and 64-bit architectures. Signed-off-by: Tim Pambor <tim.pambor@codewrights.de>
tpambor
force-pushed
the
c11-thread-zassert
branch
from
caca6aa to
088c900
Compare
aescolar
approved these changes
Oct 8, 2025
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
stephanosio
approved these changes
Oct 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cast
uintptr_ttounsigned long longand adjust format specifier accordingly to ensure compatibility on both 32-bit and 64-bit architectures.Fixes the following warning:
Part of: #96968