libc + posix: signal.h + time.h: fix typos and avoid redeclaration warnings / errors #97472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfriedt
force-pushed
the
posix-signal-always-use-time-t-from-time-h
branch
from
34c10f3 to
1006361
Compare
cfriedt
changed the title
cfriedt
force-pushed
the
posix-signal-always-use-time-t-from-time-h
branch
2 times, most recently
from
fb423c7 to
6513fbe
Compare
zephyrbot
requested review from
aescolar,
keith-packard,
nashif and
stephanosio
Indicate that C library headers have declared `struct sigevent` and `struct sigval` to avoid redefinition warnings / errors. Signed-off-by: Chris Friedt <cfriedt@tenstorrent.com>
cfriedt
force-pushed
the
posix-signal-always-use-time-t-from-time-h
branch
from
6513fbe to
24b2761
Compare
Member
Author
|
cfriedt
changed the title
cfriedt
changed the title
8 tasks
added 6 commits
October 14, 2025 15:08
In order to avoid multiple definition errors, indicate that struct timespec is declared. Signed-off-by: Chris Friedt <cfriedt@tenstorrent.com>
In order to avoid multiple definition errors, indicate that struct timeval is declared. Signed-off-by: Chris Friedt <cfriedt@tenstorrent.com>
Avoid redefining `time_t` by always including the definition from `<time.h>`, since the C library may use something other than `long`. This is still safe according to the specification, since it explicitly states: > Inclusion of the <signal.h> header may make visible all symbols from > the <time.h> header. For more information, please see https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/signal.h.html Signed-off-by: Chris Friedt <cfriedt@tenstorrent.com>
C11 requires `<time.h>` to define `struct timespec`, so do not define it when C11 is already known. Signed-off-by: Chris Friedt <cfriedt@tenstorrent.com>
A previous typo went undetected that declared a type-defined `timespec_t`, which is obviously incorrect, since it is only specified as `struct timespec`. Signed-off-by: Chris Friedt <cfriedt@tenstorrent.com>
A previous typo went undetected that declared a type-defined `sigevent_t`, which is obviously incorrect, since it is only specified as `struct sigevent`. Signed-off-by: Chris Friedt <cfriedt@tenstorrent.com>
cfriedt
force-pushed
the
posix-signal-always-use-time-t-from-time-h
branch
from
24b2761 to
c148cf3
Compare
ycsin
reviewed
Oct 14, 2025
|
|
||
| #if defined(_POSIX_REALTIME_SIGNALS) || defined(__DOXYGEN__) | ||
|
|
||
| union sigval; /* forward declaration (to preserve spec order) */ |
Member
There was a problem hiding this comment.
Just wondering - can't we keep it as-is?
Member
Author
There was a problem hiding this comment.
We can't.
diff --git a/lib/posix/options/Kconfig.device_io b/lib/posix/options/Kconfig.device_io
index 416ccf74a62..71ff6b7b81c 100644
--- a/lib/posix/options/Kconfig.device_io
+++ b/lib/posix/options/Kconfig.device_io
@@ -6,7 +6,7 @@ menu "POSIX device I/O"
config POSIX_DEVICE_IO
bool "POSIX device I/O"
- select REQUIRES_FULL_LIBC
+ #select REQUIRES_FULL_LIBC
select ZVFS
select ZVFS_POLL
select ZVFS_SELECTwest build -p -b qemu_riscv64 -t run tests/posix/signals/ -- -DCONFIG_MINIMAL_LIBC=y -DCONFIG_COMPILER_WARNINGS_AS_ERRORS=y
...
/home/cfriedt/zephyrproject/zephyr/include/zephyr/posix/posix_signal.h:109:22: error: field 'sigev_value' has incomplete type
109 | union sigval sigev_value;
| ^~~~~~~~~~~
Member
Author
There was a problem hiding this comment.
Note
You can check out #97152, and then run the command above successfully (POSIX_DEVICE_IO also does not select REQUIRES_FULL_LIBC)
added 2 commits
October 15, 2025 01:41
In order to avoid warnings, declare `union sigval` ahead of `struct sigevent` and declare `siginfo_t` ahead of `struct sigaction`. Signed-off-by: Chris Friedt <cfriedt@tenstorrent.com>
Previously, the `sigev_notify_function` field was missing from `struct sigevent`. Additionally, `sigev_notify_attributes` were incorrectly named `sigev_thread_attr`. Add it back to ensure that we are able to support realtime signals. Signed-off-by: Chris Friedt <cfriedt@tenstorrent.com>
cfriedt
force-pushed
the
posix-signal-always-use-time-t-from-time-h
branch
from
c148cf3 to
4510cc8
Compare
|
jhedberg
approved these changes
Oct 15, 2025
ycsin
approved these changes
Oct 15, 2025
Member
Author
|
@stephanosio - are you able to review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change corrects 2 typos in
posix_signal.handposix_time.hand additionally ensures that libc definitions ofstruct timespecare indicated via macro to avoid redefinition warnings / errors.time_tdefinition from libcstruct timespecwhen >= c11timepsecis a struct not a typedefsigeventis a struct not a typedefsigvalis declaredsigev_notify_functionfield instruct sigeventThe issues do not affect CI or build status at the moment but do block changes slated for v4.3.0