Fix DCMIPP video driver compilation on STM32MP13 #98211
Open
+18
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 24, 2025 14:21
Correct compilation error due to usage of DCMIPP_PIPE1 / DCMIPP_PIPE2 on platform which do not have pixel pipes by putting those caps under #if defined(STM32_DCMIPP_HAS_PIXEL_PIPES) Put also DCMIPP_VIDEO_FORMAT_CAP macro inside since this is only used for AUX / MAIN pipes. Fixes: 126aaf6 ("video: dcmipp: expose dcmipp caps for all 3 pipes.") Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
Add test compilation for the STM32MP13 platform as part of drivers.video.stm32_dcmipp.build since this allow to test build the driver when STM32_DCMIPP_HAS_PIXEL_PIPES is not defined. Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
zephyrbot
added
area: Video
zephyrbot
requested review from
FRASTM,
GeorgeCGV,
djiatsaf-st,
erwango,
etienne-lms,
gautierg-st,
josuah,
loicpoulain,
marwaiehm-st,
mathieuchopstm,
nashif and
ngphibang
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #94562 introduced a regression in build of the DCMIPP driver for the STM32MP13 due to the fact that on STM32MP13, the DCMIPP do not have PIPE1 and PIPE2.
The PR fixes this by enclosing PIPE1 (main) / PIPE2 (aux) caps within the proper preproc if statement as done in order part of the code.
Moreover, in order to avoid such future issue, add test build of dcmipp for the MP13 platform. That done, test build is done in the 2 variants of the DCMIPP driver.