scripts: runners: generalize dry run #98443
Open
+21
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mbolivar would appreciate a review as per the discussion in #98018 (comment) |
Move the argparse.add_argument() call to the abstract base class and augment the RunnerCaps class with a dry_run parameter. Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
In order to avoid duplication of logic in runners, allow subclasses of ZephyrBinaryRunner to set self.dry_run so that they can then reuse the logic in core.py to log instead of execute. Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
carlescufi
force-pushed
the
generalize-dry-run
branch
from
2abb255 to
7af2c99
Compare
carlescufi
changed the title
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
pdgendt
approved these changes
Nov 3, 2025
mbolivar
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_DRY_RUNshould remain unaffected, but subclasses can now setself.dry_runand then use the base classe methods (_log_cmd(),call(),check_call()andcheck_output()) directly without having to implement the logic themselves