Fix SPI loopback CS testing race condition in GPIO callback #98448
+56
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If rx and tx length are both 0 in dma path then do nothing. Signed-off-by: Declan Snyder <declan.snyder@nxp.com>
There is a race condition in this method of CS behavior verification, where multiple CS signal transitions can happen during one interrupt processing, thereby only getting one callback and marking the trigger count as being less than what is accurate. At least we can account for most real situations where this happens by also looking at the CS pin logic level and comparing to how it started, to potentially realize that there was another edge that happened when it either should or shouldn't have happened. Signed-off-by: Declan Snyder <declan.snyder@nxp.com>
zephyrbot
added
area: Tests
zephyrbot
requested review from
dbaluta,
dleach02,
manuargue,
mmahadevan108,
nashif,
tbursztyka and
teburd
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a race condition in this method of CS behavior verification,
where multiple CS signal transitions can happen during one interrupt
processing, thereby only getting one callback and marking the trigger
count as being less than what is accurate. At least we can account for
most real situations where this happens by also looking at the CS pin
logic level and comparing to how it started, to potentially realize that
there was another edge that happened when it either should or shouldn't
have happened.
Also contains another fix to just report that the HOLD_ON_CS flag is not supported by the flexcomm SPI driver, because this PR is originally for fixing #95359 and both commits are related to that.
Fixes #95359 (I think)