tests: zbus: publish_stats: update thresholds #99727
Open
+10
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@katgiadla please validate on the failing hardware |
zephyrbot
added
area: Zbus
area: Tests
rodrigopex
requested changes
Nov 20, 2025
Contributor
rodrigopex
left a comment
rodrigopex
left a comment
There was a problem hiding this comment.
There is repetitive usage of a constant. Could you move that to a define or static constant with a meaningful name? That would reduce maintenance effort.
`zbus_chan_pub_stats_msg_age` returns milliseconds, while `clock_window` is in clock ticks. Update the thresholds to refer to the same 50ms window as `clock_window`. Fixes zephyrproject-rtos#99500. Signed-off-by: Jordan Yates <jordan@embeint.com>
JordanYates
force-pushed
the
251120_zbus_pub_stats
branch
from
b6de3ad to
084924e
Compare
|
rodrigopex
approved these changes
Nov 21, 2025
pdgendt
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zbus_chan_pub_stats_msg_agereturns milliseconds, whileclock_windowis in clock ticks. Update the thresholds to refer to the same 50ms window asclock_window.Fixes #99500.