-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MULTI ZNS] MAIN #121
Open
Whytecrowe
wants to merge
125
commits into
development
Choose a base branch
from
rc/multi-zns-main
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[MULTI ZNS] MAIN #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k to just be a generic erc20 because of issues with nested deps in hardhat
…into feat/modify-transfers
…anged. Deleted redundant approvals. Mock token fix.
…st for use of safeTransferFrom checks
[MULTI ZNS] MAIN
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development #121 +/- ##
===============================================
+ Coverage 99.80% 99.82% +0.02%
===============================================
Files 11 12 +1
Lines 512 576 +64
Branches 127 129 +2
===============================================
+ Hits 511 575 +64
Misses 1 1 |
This was referenced Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main Branch for the 2nd release of ZNS that works cross-chain.
ZNS Ethereum will be upgraded based on this code and ZNS ZChain will be deployed from this code.
All PRs that work on the new ZNS for Mainnet will be merged here.
DO NOT MERGE THIS PR!