Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug 🐞]: [ISRU.cfg] #58

Closed
zer0Kerbal opened this issue Feb 27, 2022 · 2 comments · Fixed by #60
Closed

[Bug 🐞]: [ISRU.cfg] #58

zer0Kerbal opened this issue Feb 27, 2022 · 2 comments · Fixed by #60
Assignees
Labels
bug 🐛 An issue with the system. Something isn't working... KSC... we have an error code issue: compatibility/patch issue type

Comments

@zer0Kerbal
Copy link
Owner

Brief description of your issue

Kaa253
Kaa253

I don't think it was smelting metal with the ISRUs.
I think ISRU.cfg needs to be HAS[#ConverterName[Mono*]] like this...

@PART[*ISRU*,Smelter*]:NEEDS[LaunchPad,SimpleConstruction]:FOR[SimpleConstruction]
{
	+MODULE[ModuleResourceConverter]:HAS[#ConverterName[Mono*]]
	{
		@ConverterName = Metal

Steps to reproduce

install SCON and look at file

Expected behavior

not this

Actual behavior

patch not effective

Environment

unk

How did you download and install this?

Other (explain below)

@zer0Kerbal zer0Kerbal added bug 🐛 An issue with the system. Something isn't working... KSC... we have an error code issue: compatibility/patch issue type labels Feb 27, 2022
@zer0Kerbal zer0Kerbal added this to the 4.0.99.1-prerelease milestone Feb 27, 2022
@zer0Kerbal zer0Kerbal self-assigned this Feb 27, 2022
@zer0Kerbal zer0Kerbal changed the title [Bug 🐞]: [Bug 🐞]: [ISRU.cfg] Feb 27, 2022
@zer0Kerbal
Copy link
Owner Author

thank you - updated patch, now is more straightforward. also is localized.

@zer0Kerbal
Copy link
Owner Author

  • [ISRU.cfg] v1.1.0.0
    • Add Localization
    • [ORE to METAL]
      • convert +MODULE to MODULE (adds entire module instead of patching a copy
    • [ORE to Karbonite]
      • convert +MODULE to MODULE (adds entire module instead of patching a copy
      • adjust [Karbonite] to [metal] conversion from 5:1 to 3:1
    • closes [Bug 🐞]: [ISRU.cfg] #58 - [Bug 🐞]: [ISRU.cfg]

zer0Kerbal added a commit that referenced this issue Feb 27, 2022
* [ISRU.cfg] v1.1.0.0
  * Add Localization
  * [ORE to METAL]
    * convert +MODULE to MODULE (adds entire module instead of patching a copy
  * [ORE to Karbonite]
    * convert +MODULE to MODULE (adds entire module instead of patching a copy
    * adjust [Karbonite] to [metal] conversion from 5:1 to 3:1
  * closes #58 - [Bug 🐞]: [ISRU.cfg]
zer0Kerbal added a commit that referenced this issue Feb 27, 2022
## Version 4.0.99.1 - A tiny Hammer

* 26 Feb 2022
* Release for Kerbal Space Program [KSP 1.12.3]

### Updated

* [Tanks.cfg]
  * blame: Version 4.0.9.9.1-prerelease
  * was accidentally changing [name] of stock tanks. spanked patch. all better now.
  * was supposed to be only changing the [title]
  * include [ghostparts.cfg] to try to prevent further damage to game saves.
  * thank you to [Kaa253](https://forum.kerbalspaceprogram.com/index.php?/profile/68628-kaa253/) for reporting this

* [ISRU.cfg] v1.1.0.0
  * Add Localization
  * [ORE to METAL]
    * convert +MODULE to MODULE (adds entire module instead of patching a copy
  * [ORE to Karbonite]
    * convert +MODULE to MODULE (adds entire module instead of patching a copy
    * adjust [Karbonite] to [metal] conversion from 5:1 to 3:1
  * thank you to [Kaa253](https://forum.kerbalspaceprogram.com/index.php?/profile/68628-kaa253/) for reporting this
  * closes #58 - [Bug 🐞]: [ISRU.cfg]

* [en-us.cfg] v1.1.0.0
  * add ISRU localizations
  * add header/footer
  * seems USI hasn't localized Karbonite/KarbonitePlus
    * [#SCON-Karbonite-ConverterName] = Karbonite
    * [#SCON-Karbonite-StartActionName] = Karbonite Refining: Start
    * [#SCON-Karbonite-StopActionName] = Karbonite Refining: Stop
    * [#SCON_Karbonite_displayname] = Karbonite

* Spawn Location
  * no reports of further bad behavior
  * closes #38 - Correct Spawn location

### Created

* [ghostparts.cfg] v1.0.0.0
  * has a shelf life and will go away
  * creates hidden parts that should not show in editor, but available for in flight craft.
  * closes #57 - [Bug 🐞]: [Tanks.cfg] changing stock part name

### Backend

* folder maintenance
* moved Patches --> Compatibility
* update automation to latest version
* convert _release.json to schema 1.0.2.1

### Kerbal Changelog

* convert [Changelog.kcl]
  * from Kerbal Changelog format to GitHub flavored markdown
  * closes #59 - Convert Changelog.cfg

### Docs/

* update [readme.md] v1.6.5.6
* update [changelog.md] v1.4.1.0
* add [Attribution.md] v1.1.0.0
* /Localization
* [LegalMumboJumbo]
* [Part-Invoice]
* ReleaseNotes/
  * [4.0.2.4]
  * [4.0.2.5]
  * [4.0.2.6]
  * [4.0.2.7]
  * [4.0.9.9]
  * [4.0.9.9.1]
  * [4.0.99.1]

### Status

* Issues/Milestones
  * closes #56 - 4.0.99.1 Social Media
  * closes #55 - 4.0.99.1 Update documentation
  * closes #54 - 4.0.99.1 Verify Legal MumboJumbo
  * closes #53 - Release 4.0.99.1-prerelease <A Tiny Hammer>
  * closes #50 - (Short List) SimpleConstruction Version 4.0.99.1-prerelease due to new version of EL: 6.99.1
* Pull Requests
  * closes #48 - 4.0.9.9.1 prerelease - A Bigger Hammer

* [ELWorkshop]
  * newly discovered KSPFields
  * bool FullyEquipped;
  * bool - IgnoreCrewCapacity = true;
  * float - ProductivityFactor = 1f;
  * float - UnmannedProductivity;
zer0Kerbal added a commit that referenced this issue Feb 27, 2022
## Version 4.0.99.1 - A tiny Hammer

* 26 Feb 2022
* Release for Kerbal Space Program [KSP 1.12.3]

### Updated

* [Tanks.cfg]
  * blame: Version 4.0.9.9.1-prerelease
  * was accidentally changing [name] of stock tanks. spanked patch. all better now.
  * was supposed to be only changing the [title]
  * include [ghostparts.cfg] to try to prevent further damage to game saves.
  * thank you to [Kaa253](https://forum.kerbalspaceprogram.com/index.php?/profile/68628-kaa253/) for reporting this

* [ISRU.cfg] v1.1.0.0
  * Add Localization
  * [ORE to METAL]
    * convert +MODULE to MODULE (adds entire module instead of patching a copy
  * [ORE to Karbonite]
    * convert +MODULE to MODULE (adds entire module instead of patching a copy
    * adjust [Karbonite] to [metal] conversion from 5:1 to 3:1
  * thank you to [Kaa253](https://forum.kerbalspaceprogram.com/index.php?/profile/68628-kaa253/) for reporting this
  * closes #58 - [Bug 🐞]: [ISRU.cfg]

* [en-us.cfg] v1.1.0.0
  * add ISRU localizations
  * add header/footer
  * seems USI hasn't localized Karbonite/KarbonitePlus
    * [#SCON-Karbonite-ConverterName] = Karbonite
    * [#SCON-Karbonite-StartActionName] = Karbonite Refining: Start
    * [#SCON-Karbonite-StopActionName] = Karbonite Refining: Stop
    * [#SCON_Karbonite_displayname] = Karbonite

* Spawn Location
  * no reports of further bad behavior
  * closes #38 - Correct Spawn location

### Created

* [ghostparts.cfg] v1.0.0.0
  * has a shelf life and will go away
  * creates hidden parts that should not show in editor, but available for in flight craft.
  * closes #57 - [Bug 🐞]: [Tanks.cfg] changing stock part name

### Backend

* folder maintenance
* moved Patches --> Compatibility
* update automation to latest version
* convert _release.json to schema 1.0.2.1

### Kerbal Changelog

* convert [Changelog.kcl]
  * from Kerbal Changelog format to GitHub flavored markdown
  * closes #59 - Convert Changelog.cfg

### Docs/

* update [readme.md] v1.6.5.6
* update [changelog.md] v1.4.1.0
* add [Attribution.md] v1.1.0.0
* /Localization
* [LegalMumboJumbo]
* [Part-Invoice]
* ReleaseNotes/
  * [4.0.2.4]
  * [4.0.2.5]
  * [4.0.2.6]
  * [4.0.2.7]
  * [4.0.9.9]
  * [4.0.9.9.1]
  * [4.0.99.1]

### Status

* Issues/Milestones
  * closes #56 - 4.0.99.1 Social Media
  * closes #55 - 4.0.99.1 Update documentation
  * closes #54 - 4.0.99.1 Verify Legal MumboJumbo
  * closes #53 - Release 4.0.99.1-prerelease <A Tiny Hammer>
  * closes #50 - (Short List) SimpleConstruction Version 4.0.99.1-prerelease due to new version of EL: 6.99.1
* Pull Requests
  * closes #48 - 4.0.9.9.1 prerelease - A Bigger Hammer

* [ELWorkshop]
  * newly discovered KSPFields
  * bool FullyEquipped;
  * bool - IgnoreCrewCapacity = true;
  * float - ProductivityFactor = 1f;
  * float - UnmannedProductivity;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 An issue with the system. Something isn't working... KSC... we have an error code issue: compatibility/patch issue type
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant