Changeset - incorrect open status with timezone != utc-0

[mmd-osm]

Situation: CGImap runs on a server in UTC+2 timezone. The changeset call /api/0.6/changeset/xxx returns a changeset where the status is "closed", although the changeset will only close 1 hour in the future. For further discussion see details at streetcomplete/StreetComplete#562 (comment)

now is initialized with local time (which is UTC+2):

openstreetmap-cgimap/src/main.cpp

Line 183 in 83185f5

pt::ptime now(pt::second_clock::local_time());

Comparison doesn't take UTC+2 / UTC+0 difference into account:

openstreetmap-cgimap/src/output_formatter.cpp

Lines 59 to 62 in fdc2523

	bool changeset_info::is_open_at(const pt::ptime &now) const {
	const pt::ptime closed_at_time = parse_time(closed_at);
	return (closed_at_time > now) && (num_changes < MAX_CHANGESET_ELEMENTS);
	}

Processing should be based on UTC+0, regardless of the local timezone.

[tomhughes]

Note that all OSM servers run in UTC all the time anyway.

[mmd-osm]

Right, I wanted to keep this in line with what we did here: openstreetmap/openstreetmap-website#1688, i.e. no hard requirement to run on UTC+0 timezone.

[tomhughes]

So just change local_time to universal_time then ;-)