Refactor: boost date/time functions #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zerebubuth, @tomhughes, @pnorman : I like to drop one boost library dependency in this pull request, and at the same time introduce a minimum gcc version 5.x for cgimap due to I'd appreciate a few additional opinions, if this is a good idea, or if I'd better provide some 4.x friendly replacement for |
|
No complaints from me. |
|
This would break the RHEL/CentOS 7 support (with gcc 4.8), but I believe nobody runs the Rails Port under that. Ubuntu 16.04 has 5.3, so that change would be okay. |
|
Thanks everyone for your feedback, I just merged this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request replaces boost date/time functions by their c++11 counterpart. Dependency on boost date-time library is also dropped as part of this pr.
gcc 5.x or newer is required, due to
std::put_time- requirement fulfilled by Ubuntu Xenial or newer(Closes #150)